From: Michael Straube <straube.linux@gmail.com>
To: Pkshih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions
Date: Fri, 13 Dec 2019 12:46:21 +0100 [thread overview]
Message-ID: <84f3ec5e-eda7-c955-2705-482263eb1ee6@gmail.com> (raw)
In-Reply-To: <1576115241.2733.1.camel@realtek.com>
On 2019-12-12 02:47, Pkshih wrote:
> On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote:
>> This series converts the drivers rtl8192{ce,cu,de} to use the generic
>> functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
>>
>> Michael Straube (6):
>> rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
>> rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
>> rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
>>
>> .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++----------------
>> .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++-----------------
>> .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++----------------
>> 3 files changed, 14 insertions(+), 130 deletions(-)
>>
>
> For all patches:
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
Thanks.
> Curiously. How can you find these function are identical?
>
While sending cleanup patches for some staging wifi drivers I noticed
that these functions are used in many of the realtek drivers and all
looked very similar. Then used grep and diff to verify.
Michael
prev parent reply other threads:[~2019-12-13 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
2019-12-18 19:07 ` Kalle Valo
2019-12-11 15:47 ` [PATCH 2/6] rtlwifi: rtl8192cu: " Michael Straube
2019-12-11 15:47 ` [PATCH 3/6] rtlwifi: rtl8192de: " Michael Straube
2019-12-11 15:47 ` [PATCH 4/6] rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping Michael Straube
2019-12-11 15:47 ` [PATCH 5/6] rtlwifi: rtl8192cu: " Michael Straube
2019-12-11 15:47 ` [PATCH 6/6] rtlwifi: rtl8192de: " Michael Straube
2019-12-12 1:47 ` [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Pkshih
2019-12-13 11:46 ` Michael Straube [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f3ec5e-eda7-c955-2705-482263eb1ee6@gmail.com \
--to=straube.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.