All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 07/11] i2c: designware: Discard Cherry Trail model flag
Date: Mon, 1 Jun 2020 11:54:10 +0300	[thread overview]
Message-ID: <85f326ac-7a11-f405-7830-abda4e8b0879@linux.intel.com> (raw)
In-Reply-To: <20200528100635.GH1634618@smile.fi.intel.com>

On 5/28/20 1:06 PM, Andy Shevchenko wrote:
> On Thu, May 28, 2020 at 12:33:17PM +0300, Serge Semin wrote:
>> A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed
>> since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C
>> bus pm_disabled workaround"), but the flag most likely by mistake has been
>> left in the Dw I2C drivers. Let's remove it. Since MODEL_MSCC_OCELOT is
>> the only model-flag left, redefine it to be 0x100 so setting a very first
>> bit in the MODEL_MASK bits range.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Conditionally, in case Wolfram and Jarkko are fine with shuffling model
> defines, which I consider an unneeded churn.
> 
>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

I completely agree with Andy and more over, I didn't ack this version. 
This was the version I acked:

https://www.spinics.net/lists/linux-i2c/msg45492.html

So in general please drop the received tags in case you decide to modify 
patch since reviewers may not agree anymore with it.

That said, I'm fine with that minor code and commit log change. And 
don't want to have yet another patchset version because it. Four 
patchset versions during 2 days is a bit too much... Usual 
recommendation is to wait for 1 week before posting a new version 
especially if patchset is under active discussion.

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

  reply	other threads:[~2020-06-01  8:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  9:33 [PATCH v6 00/11] i2c: designeware: Add Baikal-T1 System I2C support Serge Semin
2020-05-28  9:33 ` [PATCH v6 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema Serge Semin
2020-05-30  9:39   ` Wolfram Sang
2020-05-30 10:24     ` Serge Semin
2020-05-30 11:10       ` Wolfram Sang
2020-05-28  9:33 ` [PATCH v6 02/11] dt-bindings: i2c: Convert DW I2C slave to the DW I2C master example Serge Semin
2020-05-29 19:17   ` Rob Herring
2020-05-28  9:33 ` [PATCH v6 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller Serge Semin
2020-05-29 19:18   ` Rob Herring
2020-05-28  9:33 ` [PATCH v6 04/11] i2c: designware: Use `-y` to build multi-object modules Serge Semin
2020-05-28  9:33 ` [PATCH v6 05/11] i2c: designware: slave: Set DW I2C core module dependency Serge Semin
2020-05-28  9:33 ` [PATCH v6 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency Serge Semin
2020-05-28  9:33 ` [PATCH v6 07/11] i2c: designware: Discard Cherry Trail model flag Serge Semin
2020-05-28 10:06   ` Andy Shevchenko
2020-06-01  8:54     ` Jarkko Nikula [this message]
2020-05-28  9:33 ` [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API Serge Semin
2020-05-28 10:04   ` Andy Shevchenko
2020-05-30 11:09   ` Wolfram Sang
2020-05-30 21:05     ` Wolfram Sang
2020-05-31 17:12       ` Serge Semin
2020-05-28  9:33 ` [PATCH v6 09/11] i2c: designware: Retrieve quirk flags as early as possible Serge Semin
2020-05-28  9:33 ` [PATCH v6 10/11] i2c: designware: Move reg-space remapping into a dedicated function Serge Semin
2020-05-28  9:33 ` [PATCH v6 11/11] i2c: designware: Add Baikal-T1 System I2C support Serge Semin
2020-05-30 21:06 ` [PATCH v6 00/11] i2c: designeware: " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85f326ac-7a11-f405-7830-abda4e8b0879@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.