All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Amir Goldstein <amir73il@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_io/lsattr: expose FS_XFLAG_HASATTR flag
Date: Fri, 8 Nov 2019 07:39:30 -0600	[thread overview]
Message-ID: <8659f5a5-0a38-2f35-39fd-64dc2c7fe2fa@sandeen.net> (raw)
In-Reply-To: <20191108065017.GN6219@magnolia>

On 11/8/19 12:50 AM, Darrick J. Wong wrote:
> On Wed, Nov 06, 2019 at 07:58:55AM +0200, Amir Goldstein wrote:
>> For efficient check if file has xattrs.
>>
>> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> ---
>>  io/attr.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/io/attr.c b/io/attr.c
>> index b713d017..ba88ef16 100644
>> --- a/io/attr.c
>> +++ b/io/attr.c
>> @@ -37,6 +37,7 @@ static struct xflags {
>>  	{ FS_XFLAG_FILESTREAM,		"S", "filestream"	},
>>  	{ FS_XFLAG_DAX,			"x", "dax"		},
>>  	{ FS_XFLAG_COWEXTSIZE,		"C", "cowextsize"	},
>> +	{ FS_XFLAG_HASATTR,		"X", "has-xattr"	},
> 
> This causes an xfs/207 regression on the extra letter in the output; can
> you please fix that?

I sent [PATCH] xfs/207: explicitly test for xflag character 

but forgot to cc xfs list.  it's on the fstests list, sorry!

-Eric

      reply	other threads:[~2019-11-08 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  5:58 [PATCH] xfs_io/lsattr: expose FS_XFLAG_HASATTR flag Amir Goldstein
2019-11-06 16:01 ` Darrick J. Wong
2019-11-06 18:29   ` Amir Goldstein
2019-11-06 18:45     ` Eric Sandeen
2019-11-06 18:52       ` Darrick J. Wong
2019-11-06 18:53         ` Eric Sandeen
2019-11-06 19:07           ` Darrick J. Wong
2019-11-08  6:50 ` Darrick J. Wong
2019-11-08 13:39   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8659f5a5-0a38-2f35-39fd-64dc2c7fe2fa@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.