All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	<git@vger.kernel.org>, Jonathan Nieder <jrnieder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Date: Fri, 13 Apr 2012 13:33:22 +0200	[thread overview]
Message-ID: <871unrzx19.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <20120413105238.GE2164@goldbirke> ("SZEDER =?utf-8?Q?G=C3=A1b?= =?utf-8?Q?or=22's?= message of "Fri, 13 Apr 2012 12:52:38 +0200")

SZEDER Gábor <szeder@ira.uka.de> writes:

> On Fri, Apr 13, 2012 at 01:34:46PM +0300, Felipe Contreras wrote:
>> >> +     run_completion "git f" &&
>> >> +     ! grep -q -v "^f" out
>> >
>> > grep is not a git command, so I'm not sure, but shouldn't these use
>> > 'test_must_fail grep' instead of '! grep'?
>> 
>> I'm not sure. Junio has already queued this, maybe you should send a
>> patch on top of that.
>
> It seems that both are used in the test suite, but '! grep' is more
> common, so perhaps it's good as it is.
>
> $ git grep '! grep' -- t |wc -l
> 136
> $ git grep 'test_must_fail grep' -- t |wc -l
> 17

test_must_fail catches a segfault or other signal exit as "bad", unlike
! which would accept this.

Since we trust the platform tools to work (on the grounds that you have
bigger problems if they don't), ! grep is fine.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-04-13 11:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 21:57 [PATCH v2] tests: add initial bash completion tests Felipe Contreras
2012-04-11 23:48 ` Junio C Hamano
2012-04-12 16:15 ` Felipe Contreras
2012-04-12 17:43   ` Junio C Hamano
2012-04-12 23:18     ` Felipe Contreras
2012-04-12 23:26       ` Junio C Hamano
2012-04-13 19:45         ` Junio C Hamano
2012-04-13  9:12 ` SZEDER Gábor
2012-04-13  9:45   ` SZEDER Gábor
2012-04-13 10:48     ` Felipe Contreras
2012-04-13 11:14       ` SZEDER Gábor
2012-04-13 11:56         ` Felipe Contreras
2012-04-13 10:34   ` Felipe Contreras
2012-04-13 10:52     ` SZEDER Gábor
2012-04-13 11:33       ` Thomas Rast [this message]
2012-04-13 19:48   ` Junio C Hamano
2012-04-14  2:06     ` Felipe Contreras
2012-04-17  0:31 ` SZEDER Gábor
2012-04-17  6:32   ` Felipe Contreras
2012-04-17 10:22     ` SZEDER Gábor
2012-04-17 10:27       ` [PATCH] tests: add tests for the __gitcomp() completion helper function SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871unrzx19.fsf@thomas.inf.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.