From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests
Date: Fri, 05 Jun 2020 18:46:30 +0100 [thread overview]
Message-ID: <8736794d8p.fsf@linaro.org> (raw)
In-Reply-To: <f8c9afba-4c7c-a410-f42c-c63aa2128ef6@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> On 6/5/20 7:11 AM, Alex Bennée wrote:
>> @@ -467,7 +467,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
>> * It can fail only on 64-bit host with 32-bit target.
>> * On any other target/host host mmap() handles this error correctly.
>> */
>> - if (!guest_range_valid(start, len)) {
>> + if (end < start || !guest_range_valid(start, len)) {
>> errno = ENOMEM;
>> goto fail;
>> }
>
> Interesting. I was adjusting guest_range_valid tagged pointers yesterday, and
> thought that it looked buggy.
Should be picking this up in guest_range_valid?
--
Alex Bennée
next prev parent reply other threads:[~2020-06-05 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:43 [PULL v2 00/13] testing, tcg and plugin updates Alex Bennée
2020-05-15 14:43 ` [PULL v2 01/13] tests/guest-debug: catch hanging guests Alex Bennée
2020-05-15 14:43 ` [PULL v2 02/13] travis.yml: Improve the --disable-tcg test on s390x Alex Bennée
2020-05-15 14:43 ` [PULL v2 03/13] linux-user: completely re-write init_guest_space Alex Bennée
2020-05-15 14:43 ` [PULL v2 04/13] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-05-15 14:43 ` [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-06-04 14:15 ` Laurent Vivier
2020-06-04 17:31 ` Alex Bennée
2020-06-05 14:11 ` Alex Bennée
2020-06-05 17:38 ` Richard Henderson
2020-06-05 17:46 ` Alex Bennée [this message]
2020-06-05 18:26 ` Richard Henderson
2020-05-15 14:43 ` [PULL v2 06/13] accel/tcg: don't disable exec_tb trace events Alex Bennée
2020-05-15 14:43 ` [PULL v2 07/13] disas: include an optional note for the start of disassembly Alex Bennée
2020-05-15 14:44 ` [PULL v2 08/13] disas: add optional note support to cap_disas Alex Bennée
2020-05-15 14:44 ` [PULL v2 09/13] translate-all: include guest address in out_asm output Alex Bennée
2020-05-15 14:44 ` [PULL v2 10/13] qemu/plugin: Trivial code movement Alex Bennée
2020-05-15 14:44 ` [PULL v2 11/13] qemu/plugin: Move !CONFIG_PLUGIN stubs altogether Alex Bennée
2020-05-15 14:44 ` [PULL v2 12/13] qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const Alex Bennée
2020-05-15 14:44 ` [PULL v2 13/13] MAINTAINERS: update the orphaned cpus-common.c file Alex Bennée
2020-05-15 15:46 ` [PULL v2 00/13] testing, tcg and plugin updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736794d8p.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.