From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIarW-0007qP-Qh
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:14:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIarS-0003rI-I2
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:14:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48023)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIarS-0003rC-CV
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:14:26 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466777957-5126-3-git-send-email-armbru@redhat.com>
	<1467268211-11451-1-git-send-email-armbru@redhat.com>
	<874m8baqoh.fsf@oc4731375738.ibm.com>
Date: Thu, 30 Jun 2016 14:14:23 +0200
In-Reply-To: <874m8baqoh.fsf@oc4731375738.ibm.com> (Sascha Silbe's message of
	"Thu, 30 Jun 2016 12:58:54 +0200")
Message-ID: <874m8aan6o.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com

Sascha Silbe <silbe@linux.vnet.ibm.com> writes:

> Dear Markus,
>
> Markus Armbruster <armbru@redhat.com> writes:
>
>> ---
>>  tests/header-test-template.c | 16 ++++++++++++++++
> [...]
>
> Thanks, that helped, I get a bit further now.
>
> Is "make header-check" supposed to work on a host that doesn't have all
> optional dependencies installed? It fails for me because some OpenGL
> related header is missing. configure correctly detected that and didn't
> enable OpenGL support:
>
> $ make check-headers
>   CC    tests/headers/include/ui/shader.o
> In file included from tests/headers/include/ui/shader.c:14:0:
> ./include/ui/shader.h:6:22: fatal error: epoxy/gl.h: No such file or directory
>  #include <epoxy/gl.h>
>                       ^
> compilation terminated.
> make: *** [tests/headers/include/ui/shader.o] Error 1
> rm tests/headers/include/ui/shader.c
> $ grep OPENGL config-host.*

Hmm, this demonstrates some of our headers may only be included when
certain CONFIG_* are defined.

Actually, I ran into a related case myself: headers that don't compile
with CONFIG_WIN32.

We can either add suitable ifdeffery to make our headers work always, or
mark headers so the test skips them when their requirements aren't met,
similarly to how this patch skips certain headers when CONFIG_WIN32 is
defined.

Regardless, we need to find the problemtatic headers.  Perhaps you can
find a few more with "make -k check-source".

Thanks!