From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjNpp-0004An-7a for qemu-devel@nongnu.org; Tue, 15 Jan 2019 07:28:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjNpo-0001xg-DY for qemu-devel@nongnu.org; Tue, 15 Jan 2019 07:28:49 -0500 From: Markus Armbruster References: <20190111140857.4211-1-philmd@redhat.com> <20190111140857.4211-4-philmd@redhat.com> Date: Tue, 15 Jan 2019 13:28:32 +0100 In-Reply-To: <20190111140857.4211-4-philmd@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 11 Jan 2019 15:08:45 +0100") Message-ID: <875zuqjea7.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Paolo Bonzini , Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Alistair Francis , Xiao Guangrong , qemu-block@nongnu.org, "Michael S. Tsirkin" , Laszlo Ersek , Peter Crosthwaite , Philippe =?utf-8?Q?Mathieu-Da?= =?utf-8?Q?ud=C3=A9?= , qemu-arm@nongnu.org, Gerd Hoffmann , Igor Mammedov Philippe Mathieu-Daud=C3=A9 writes: > From: Philippe Mathieu-Daud=C3=A9 > > There are only three files requiring this typedef, let them > include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h". > > To clean "qemu/typedefs.h", move the forward declaration > to "hw/ssi/ssi.h". > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/arm/strongarm.h | 1 + > include/hw/arm/pxa.h | 1 + > include/hw/ssi/pl022.h | 1 + > include/hw/ssi/ssi.h | 1 + > include/qemu/typedefs.h | 1 - > 5 files changed, 4 insertions(+), 1 deletion(-) When typedefs.h changes, we recompile the world, but it pretty much only ever changes when new typedefs are added. Thus, *keeping* a typedef there is therefore pretty cheap. Nevertheless, we shouldn't keep typedefs there without a real reason. Being able to move one away without having to add any new #include directives is a strong sign for "no real reason". I like patches doing that. What I don't like is adding #include directives just so you can move typedefs out of typedefs.h: it slows down the build. Granted, the four added by this patch are a drop in the bucket. The point I'm trying to make is typedefs.h's purpose: it's for avoiding #include directives. Circular ones in particular, but others, too.