Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

["Philippe Mathieu-Daudé" <f4bug@amsat.org>]

Hi Richard,

On 6/19/21 2:41 PM, Richard Henderson wrote:
> On 6/19/21 2:26 AM, Philippe Mathieu-Daudé wrote:
>>>    It doesn't seem to match the next
>>> two patches, which don't create new compilation units.
>>
>> Indeed. In a yet-to-be-posted later series they get renamed to .c,
>> becoming new units.
> 
> Ah, ok.
> 
>> What I can do is hold these patches and post them later with the
>> yet-to-be-posted series, *but* that breaks the "extract nanomips
>> from translate.c" which you already reviewed :/
> 
> I don't mind the ordering, just that there's a reason.

Is that OK if I reword as:

---
We want to extract the microMIPS ISA and Code Compaction ASE to
new compilation units.

We will first extract this code as included source files (.c.inc),
then make them new compilation units afterward.

The following methods are going to be used externally:

  micromips_translate.c.inc:1778:   gen_ldxs(ctx, rs, rt, rd);
  micromips_translate.c.inc:1806:   gen_align(ctx, 32, rd, rs, ...
  micromips_translate.c.inc:2859:   gen_addiupc(ctx, reg, offset, ...
  mips16e_translate.c.inc:444:      gen_addiupc(ctx, ry, offset, ...

To avoid too much code churn, it is simpler to declare these
prototypes in "translate.h" now.
---

?