From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A5BC5DF60 for ; Fri, 8 Nov 2019 10:56:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75D1E218AE for ; Fri, 8 Nov 2019 10:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MAn+gmY6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730151AbfKHK4l (ORCPT ); Fri, 8 Nov 2019 05:56:41 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:52825 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726149AbfKHK4l (ORCPT ); Fri, 8 Nov 2019 05:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573210600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z632feK0xo57emf6fFS5gwdIUzpWePHRoWFGwMcdBdg=; b=MAn+gmY6hP8+ZOLNyneH2SnM4CvRJCnKTzhfEu1THymRQ8I+PpZlAaeN2dfhNb9D5sNdUv hVNZG3wT8PJY6eVVt92td6/2YfpvniWHgmFwIjtflSZhnkllEAyjc9L1hfzrPKGzf+epBX zlh2fsawvlwtvZ97LzUNr8y2bPsdzYs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-KXHTCg0MNHiIbK8_Z4h99A-1; Fri, 08 Nov 2019 05:56:37 -0500 Received: by mail-lj1-f198.google.com with SMTP id o20so1169535ljg.0 for ; Fri, 08 Nov 2019 02:56:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=B9ScARlo/HyQ+QLgyEDozc6otjhcAwH0CJnAxZVp+qs=; b=JFFgZ1JRC02u4zfiZLZ5PFT0C/rUaI5anFEM7TYJtyP9oKjPb7AM/xeec2Pi8W3hqT 7CNwdn1JuPfPGrNz1CFKWoxHsNTHB3VqK0uKK3aD/LbzUSMsnZaWn4VN1Urh9K7q+5VD I0SsZBcKiEugHP0FA0EGt6nbFbrsp81DimSMt8xdbTWNaAIo9sXbA/N3uLPZ8wLzP4l6 qyT3ndPUF9etrNAehfWS2dqNZKkvbk+dXpOI+J2MAnxp1BHyzD4AqjZYFr96pE+faXKV MFW2c2Zb9mfIpL6E+oKJn99iDR58yRDjKgVuFxE5VUF3XChtC+HJcPF+fcvrsQTppA8J urpQ== X-Gm-Message-State: APjAAAWApZqoRp0JMzBOn3x6Zd5mcCTH2xKyNvY5Y6NuUtLQNMb6C/ES LgCdomaExXpjtjBkpaBEYd14RluyITlpAN3HWikie0iLJd5FVhjaXgQVEz6gL5vg3bskUpgTThb l+SEJaQmoXldqbtZ4bVav7Vv1594= X-Received: by 2002:a2e:481:: with SMTP id a1mr6439832ljf.209.1573210595635; Fri, 08 Nov 2019 02:56:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwFcYZbOdtEDfT7QaSh8Ph/WLAe9hmZ00Pfr21Wfx5hUy6ZBT/I3FE48cO9bVUQkyeCpv48Hw== X-Received: by 2002:a2e:481:: with SMTP id a1mr6439821ljf.209.1573210595508; Fri, 08 Nov 2019 02:56:35 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id x23sm810347lfe.8.2019.11.08.02.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 02:56:34 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 39B381818B5; Fri, 8 Nov 2019 11:56:34 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Kan Yan , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) In-Reply-To: <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 08 Nov 2019 11:56:34 +0100 Message-ID: <87a796fxgd.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: KXHTCg0MNHiIbK8_Z4h99A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Wed, 2019-10-23 at 11:59 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> =20 >> +void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local= , >> +=09=09=09=09=09 struct sta_info *sta, u8 ac, >> +=09=09=09=09=09 u16 tx_airtime, bool tx_completed) >> +{ >> +=09spin_lock_bh(&local->active_txq_lock[ac]); >> +=09if (tx_completed) { >> +=09=09if (sta) { >> +=09=09=09if (WARN_ONCE(sta->airtime[ac].aql_tx_pending < tx_airtime, >> +=09=09=09=09 "TXQ pending airtime underflow: %u, %u", >> +=09=09=09=09 sta->airtime[ac].aql_tx_pending, tx_airtime)) > > Maybe add the STA/AC to the message? Can do. Any idea why we might be seeing underflows (as Kan reported)? -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT1wW-0004hX-PF for ath10k@lists.infradead.org; Fri, 08 Nov 2019 10:56:42 +0000 Received: by mail-lj1-f197.google.com with SMTP id h16so1171352ljk.20 for ; Fri, 08 Nov 2019 02:56:36 -0800 (PST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) In-Reply-To: <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> Date: Fri, 08 Nov 2019 11:56:34 +0100 Message-ID: <87a796fxgd.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Kan Yan , Rajkumar Manoharan , Kevin Hayes , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau Sm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3JpdGVzOgoKPiBPbiBX ZWQsIDIwMTktMTAtMjMgYXQgMTE6NTkgKzAyMDAsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3 cm90ZToKPj4gCj4+ICAKPj4gK3ZvaWQgaWVlZTgwMjExX3N0YV91cGRhdGVfcGVuZGluZ19haXJ0 aW1lKHN0cnVjdCBpZWVlODAyMTFfbG9jYWwgKmxvY2FsLAo+PiArCQkJCQkgIHN0cnVjdCBzdGFf aW5mbyAqc3RhLCB1OCBhYywKPj4gKwkJCQkJICB1MTYgdHhfYWlydGltZSwgYm9vbCB0eF9jb21w bGV0ZWQpCj4+ICt7Cj4+ICsJc3Bpbl9sb2NrX2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2Fj XSk7Cj4+ICsJaWYgKHR4X2NvbXBsZXRlZCkgewo+PiArCQlpZiAoc3RhKSB7Cj4+ICsJCQlpZiAo V0FSTl9PTkNFKHN0YS0+YWlydGltZVthY10uYXFsX3R4X3BlbmRpbmcgPCB0eF9haXJ0aW1lLAo+ PiArCQkJCSAgICAgICJUWFEgcGVuZGluZyBhaXJ0aW1lIHVuZGVyZmxvdzogJXUsICV1IiwKPj4g KwkJCQkgICAgICBzdGEtPmFpcnRpbWVbYWNdLmFxbF90eF9wZW5kaW5nLCB0eF9haXJ0aW1lKSkK Pgo+IE1heWJlIGFkZCB0aGUgU1RBL0FDIHRvIHRoZSBtZXNzYWdlPwoKQ2FuIGRvLiBBbnkgaWRl YSB3aHkgd2UgbWlnaHQgYmUgc2VlaW5nIHVuZGVyZmxvd3MgKGFzIEthbiByZXBvcnRlZCk/Cgot VG9rZQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0 aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK