From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Martin KaFai Lau <kafai@fb.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Song Liu <songliubraving@fb.com>
Subject: Re: [Patch net-next] tcp: add a tracepoint for tcp_retransmit_skb()
Date: Thu, 12 Oct 2017 11:39:57 +0200 [thread overview]
Message-ID: <87a80wd7rm.fsf@stressinduktion.org> (raw)
In-Reply-To: <1507747095.31614.26.camel@edumazet-glaptop3.roam.corp.google.com> (Eric Dumazet's message of "Wed, 11 Oct 2017 11:38:15 -0700")
Eric Dumazet <eric.dumazet@gmail.com> writes:
[...]
> Since this sock_gen_cookie() is lock-free and IRQ ready, it should be
> not be a problem to pretend it works with a const socket.
>
> I am a bit unsure about revealing in socket cookie a precise count of
> sockets created on a netns. Some attackers might use this in a side
> channel attack.
That is true. We expose this information already via the inode number
allocator for sockets. It is a bit imprecise because of using CPU
batches.
prev parent reply other threads:[~2017-10-12 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 5:35 [Patch net-next] tcp: add a tracepoint for tcp_retransmit_skb() Cong Wang
2017-10-10 11:21 ` Eric Dumazet
2017-10-10 17:16 ` Cong Wang
2017-10-10 17:38 ` Alexei Starovoitov
2017-10-10 21:37 ` Cong Wang
2017-10-11 2:53 ` Alexei Starovoitov
2017-10-10 21:58 ` Hannes Frederic Sowa
2017-10-11 2:56 ` Alexei Starovoitov
2017-10-11 13:31 ` Eric Dumazet
2017-10-11 18:21 ` Alexei Starovoitov
2017-10-11 18:38 ` Eric Dumazet
2017-10-12 9:39 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a80wd7rm.fsf@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=alexei.starovoitov@gmail.com \
--cc=brendan.d.gregg@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kafai@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=xiyou.wangcong@gmail.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.