From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 01/22] drm: Add GEM backed framebuffer library Date: Wed, 16 Aug 2017 15:48:55 -0700 Message-ID: <87a82zp1rc.fsf@eliezer.anholt.net> References: <1502631125-13557-1-git-send-email-noralf@tronnes.org> <871sobh1e6.fsf@eliezer.anholt.net> <35a61fbd-73e0-b1d7-23c2-7d941383b7bc@tronnes.org> <3598236.UBQ02AZPRr@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1423127605==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 15FEE6E255 for ; Wed, 16 Aug 2017 22:53:49 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Laurent Pinchart Cc: narmstrong@baylibre.com, daniel.vetter@ffwll.ch, liviu.dudau@arm.com, marex@denx.de, boris.brezillon@free-electrons.com, abrodkin@synopsys.com, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, puck.chen@hisilicon.com, jsarha@ti.com, dri-devel@lists.freedesktop.org, vincent.abriou@st.com, alison.wang@freescale.com, philippe.cornu@st.com, yannick.fertre@st.com, zourongrong@gmail.com, maxime.ripard@free-electrons.com, shawnguo@kernel.org List-Id: dri-devel@lists.freedesktop.org --===============1423127605== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Den 16.08.2017 22.39, skrev Laurent Pinchart: >> Hi Noralf, >> >> On Wednesday 16 Aug 2017 21:52:02 Noralf Tr=C3=B8nnes wrote: >>> Den 16.08.2017 19.24, skrev Eric Anholt: >>>> Noralf Tr=C3=B8nnes writes: >>>>> This library provides helpers for drivers that don't subclass >>>>> drm_framebuffer and are backed by drm_gem_object. The code is >>>>> taken from drm_fb_cma_helper. >>>>> >>>>> Signed-off-by: Noralf Tr=C3=B8nnes >>>>> Reviewed-by: Daniel Vetter >>>>> --- >>>>> +/** >>>>> + * drm_gem_fb_destroy - Free GEM backed framebuffer >>>>> + * @fb: DRM framebuffer >>>>> + * >>>>> + * Frees a GEM backed framebuffer with it's backing buffer(s) and the >>>>> structure >>>> grammar nit: "its" >>>> >>>> Other than that, >>>> >>>> Reviewed-by: Eric Anholt >>> Thanks, applied to drm-misc. >> The patches were posted on Sunday. If you don't give at least a week to >> reviewers, I don't think they will keep bothering. I certainly won't. > > Hi Laurent, > > I actually didn't think there was much interest in this patchset since > the first version of the patcheset was sent 31/7. Daniel gave me his rb > if I fixed the docs a week ago. Instead of applying it directly I sent > a new version to give Eric a chance to look at it since he showed > interest in an rfc. So when I got his rb, I just applied. > > All that being said, I do appreciate reviews since that improves the work. > I will adapt to waiting a week if that's what's expected. > > Sorry about the let down. For what it's worth, I think the speed of merging was entirely appropriate in this case. It had been a week since the previous version, that got no replies except for danvet's. You're effectively just moving code and renaming some functions, and danvet and I had both replied positively. As far as concerns about whether everyone gets to give their feedback go, my stance is: The great thing about git is that you can make changes to code even after a patch goes in. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmUy9cACgkQtdYpNtH8 nuiU7Q//V4AETWmFRk942JuDgg6CV4LNg91jjsMMsK7peipza2nesEsXpiYB0n0H FkSNj+txKYDy9awthBFKPeUZonydlSpZPlXnd1oPG2YowXWiIlZiBqmkWF5ZfzfI 6GAfH7+jXlvuemizmojrAXOWHG+4GACnCTy1nmWem6yvVgX1Y4oxJ+8yWpqjBbRF 1Z36wIv6KTrOCwVYdyPeNi2NS3G47XUaRCJo6TDaregSU8pAspUGUBuuFxrveehL Qryz4AoiGh/3xJIzrtX3gnuom+fDxOWg4XJi0ek0kQ4wqdS/N+MuGCnPyia/G6ud vuAuPedG1LLuDo3E2KabZoS31qUBUG5Dz7LMap24LAro3O3hmF4Ukp41tqNHhQzk WajQEIdx7/tNhcY8gWPesg/gjD8AhSpAcJJq+Ho3mrbDBQOvnQAwp59tXwZLYHc/ smW68ziGV3mC4tDTpb27F6FBcz7afvh6j9zDBrz2v/49vU/6Fi8ZJLqQWP8uOEEa qoyMdGI3AE9lYDwYweeLApg1o0XywHXsM1mGO3KlP07IoniqcealqpwFgdFk373I CFKyMs3SylugkTheSi/aKsLeQLOOxmoxkcw/JAcPVxie22SXrQdKfvk/x4vsLpAv yZxLOnDxZpuK7xyyycYB7II472pmtIM2u+53jmuo65O/VG4H9jY= =XyA1 -----END PGP SIGNATURE----- --=-=-=-- --===============1423127605== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1423127605==--