From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
Maharaja Kennadyrajan <mkenna@codeaurora.org>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
Date: Mon, 08 Jun 2020 14:12:17 +0300 [thread overview]
Message-ID: <87blltke0e.fsf@codeaurora.org> (raw)
In-Reply-To: <19bf39e9-cee5-109f-d68f-5cbf576cc871@dd-wrt.com> (Sebastian Gottschall's message of "Sat, 30 May 2020 09:26:12 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>> Yeah, that patch is buggy but this should fix it:
>>
>> commit 32221df6765b3773ff1af37c77f8531ebc48f246
>> Author: Arnd Bergmann <arnd@arndb.de>
>> AuthorDate: Sat May 9 14:06:33 2020 +0200
>> Commit: Kalle Valo <kvalo@codeaurora.org>
>> CommitDate: Tue May 12 10:33:13 2020 +0300
>>
>> ath10k: fix ath10k_pci struct layout
> this patch seem to be totally unrelated to the crash issue, the patch
> was already part of the test tree while testing.
> the crash is caused by ar_pci->pipe_config beeing NULL on ipq4019 chipsets.
> originally pipe_config is allocated by ath10k_pci_probe. but
> ath10k_pci_probe is never used for ahb chipsets
> so the code must fix ath10k_ahb_probe to allocate these fields, or a
> more generic solution must be found
Maharaja, please investigate. It seems your patch caused a regression:
521fc37be3d8 ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-06-08 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:49 [PATCH] ath10k: Avoid override CE5 configuration for QCA99X0 chipsets Maharaja Kennadyrajan
2020-04-23 13:49 ` Maharaja Kennadyrajan
2020-05-05 7:34 ` Kalle Valo
2020-05-26 15:29 ` Sebastian Gottschall
2020-05-26 15:29 ` Sebastian Gottschall
2020-05-29 15:36 ` Kalle Valo
2020-05-29 15:36 ` Kalle Valo
2020-05-29 17:18 ` Sebastian Gottschall
2020-05-29 17:18 ` Sebastian Gottschall
2020-05-30 7:26 ` Sebastian Gottschall
2020-06-08 11:12 ` Kalle Valo [this message]
2020-05-05 7:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blltke0e.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=mkenna@codeaurora.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.