Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling

From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling
Date: Fri, 15 May 2015 10:42:14 +0200	[thread overview]
Message-ID: <87bnhmnsex.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <5554D1D9.3060108@redhat.com> (Eric Blake's message of "Thu, 14 May 2015 10:48:25 -0600")

Eric Blake <eblake@redhat.com> writes:

> On 05/12/2015 06:02 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  net/tap.c | 14 +-------------
>>  1 file changed, 1 insertion(+), 13 deletions(-)
>> 
>
>> @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, const char *name,
>>      }
>>  
>>      fcntl(fd, F_SETFL, O_NONBLOCK);
>
> Well, fcntl() could fail.  And don't we have the helper function
> util/oslib-posix.c:qemu_set_nonblock() for doing this correctly?  (Then
> again, that helper also ignores failures).
>
> But the raw use of fcntl here is pre-existing and you didn't touch it,
> so it doesn't affect my review of this patch.

I guess using the helper makes some sense here, but it's outside this
series' scope.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!