From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)
Date: Wed, 16 Sep 2020 16:51:02 +0300 [thread overview]
Message-ID: <87d02lx22h.fsf@intel.com> (raw)
In-Reply-To: <159978425524.14123.1265738591680006266@emeril.freedesktop.org>
On Fri, 11 Sep 2020, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)
> URL : https://patchwork.freedesktop.org/series/81150/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup
> -:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> #38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
> +{
> +
>
> -:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pll->info->id == DPLL_ID_EHL_DPLL4'
> #39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
> + if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))
>
> -:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
> #44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
> +
> +
>
> -:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
> #45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
> +
> +}
We have this in CI so people don't have to bother with mentioning this
stuff. But I do expect people to look at them and fix them.
BR,
Jani.
>
> total: 0 errors, 0 warnings, 4 checks, 66 lines checked
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-16 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 23:48 [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup Anusha Srivatsa
2020-09-11 0:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4) Patchwork
2020-09-16 13:51 ` Jani Nikula [this message]
2020-09-16 19:17 ` Srivatsa, Anusha
2020-09-11 0:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-11 3:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d02lx22h.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.