All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: balbi@ti.com
Cc: "Munegowda, Keshava" <keshava_mgowda@ti.com>,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
	sameo@linux.intel.com, notasas@gmail.com,
	Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue
Date: Mon, 25 Jun 2012 13:35:17 -0500	[thread overview]
Message-ID: <87d34nfdei.fsf@ti.com> (raw)
In-Reply-To: <20120622203645.GD29290@arwen.pp.htv.fi> (Felipe Balbi's message of "Fri, 22 Jun 2012 23:36:46 +0300")

Felipe Balbi <balbi@ti.com> writes:

[...]

> Keshava is reverting a fix for a HW errata. I can't accept it as it will
> cause regressions. Granted, regression by regression, there's no change,
> but I simply can't knowingly cause a regression to the driver just to
> have PM working. We need a real fix for this issue.

Sure, as long as there is a fix in this -rc cycle.

This driver intoduced changes in v3.5 that break PM for the whole SoC
(by preventing CORE retention.)  These changes were clearly not tested
with PM.

If you cannot fix this during the -rc cycle, then you need to revert the
driver PM changes that broke PM for the *whole* SoC.

Kevin

  reply	other threads:[~2012-06-25 18:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 13:42 [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue Keshava Munegowda
     [not found] ` <1340286132-20634-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-06-21 13:43   ` Munegowda, Keshava
2012-06-21 19:02     ` Kevin Hilman
     [not found]       ` <87fw9o32v2.fsf-l0cyMroinI0@public.gmane.org>
2012-06-22  7:30         ` Munegowda, Keshava
     [not found]           ` <CAP05o4KxWFjCCP05KzQgo4vWLdvOCeT=DWGXvEEnyWkomH1tXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-22 10:30             ` Felipe Balbi
     [not found]               ` <20120622103050.GG28472-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-06-22 14:14                 ` Kevin Hilman
2012-06-22 15:03                   ` Russ Dill
     [not found]                     ` <CA+Bv8XY-_x+Vh+D8sec5tvL9MkOYFKnts1WBp_AsCck2y6QNZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-22 15:11                       ` Munegowda, Keshava
     [not found]                   ` <87ehp71liv.fsf-l0cyMroinI0@public.gmane.org>
2012-06-22 20:36                     ` Felipe Balbi
2012-06-25 18:35                       ` Kevin Hilman [this message]
     [not found]                         ` <87d34nfdei.fsf-l0cyMroinI0@public.gmane.org>
2012-07-02 16:54                           ` Kevin Hilman
     [not found]                             ` <871uku85o8.fsf-l0cyMroinI0@public.gmane.org>
2012-07-02 17:05                               ` Russ Dill
     [not found]                                 ` <CA+Bv8XaC64NChdcinrxagRYLZyTG7c05nDYy2EbfH-gfZUxnuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-02 17:55                                   ` Kevin Hilman
2012-07-02 18:15                                     ` Samuel Ortiz
2012-07-03  0:14                               ` Kevin Hilman
2012-07-03  6:45                                 ` Munegowda, Keshava
2012-07-03  6:47                               ` Munegowda, Keshava
     [not found]                                 ` <CAP05o4+hxt6zY0AxK5aNW7a3Hyiw0_krP9=XK_prN5=Uk2SxmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-03  7:22                                   ` Munegowda, Keshava
2012-07-04 13:33                                     ` Kevin Hilman
2012-07-05 11:19                                       ` Samuel Ortiz
2012-07-06 10:00                                         ` Munegowda, Keshava
     [not found]                                           ` <CAP05o4JEx0uSCH+mZzLhoV479A00uUumvYY_-b8dQ9j_5Awumw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-06 11:59                                             ` Munegowda, Keshava
2012-07-11 10:29                                               ` Samuel Ortiz
2012-07-11 12:53                                                 ` Munegowda, Keshava
2012-07-11 14:23                                                   ` Kevin Hilman
     [not found]                                                     ` <874npenzq0.fsf-l0cyMroinI0@public.gmane.org>
2012-07-12  6:41                                                       ` Munegowda, Keshava
     [not found]                                                         ` <CAP05o4+hQh-weQ_hfFMxY-byEijwDF3e-D9U5gwh6yRD7C_=Zw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-19 10:17                                                           ` Munegowda, Keshava
2012-06-22 14:11             ` Kevin Hilman
2012-06-22 14:35               ` Alan Stern
     [not found]               ` <87vcij1loh.fsf-l0cyMroinI0@public.gmane.org>
2012-06-22 14:43                 ` Munegowda, Keshava
2012-06-22 18:49                   ` Kevin Hilman
2012-07-23  8:33                   ` Roger Quadros
     [not found]                     ` <500D0C42.8030508-l0cyMroinI0@public.gmane.org>
2012-07-23 11:27                       ` Munegowda, Keshava
2012-07-19 10:20 ` Felipe Balbi
     [not found]   ` <20120719102013.GJ14302-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-07-19 12:02     ` Munegowda, Keshava
2012-07-19 22:54     ` Greg KH
     [not found]       ` <20120719225405.GB32547-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-07-19 22:55         ` Greg KH
     [not found]           ` <20120719225523.GC32547-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-07-20  8:06             ` Munegowda, Keshava
2012-07-19 15:15   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d34nfdei.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=balbi@ti.com \
    --cc=keshava_mgowda@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=notasas@gmail.com \
    --cc=paul@pwsan.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.