From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E34CC433ED for ; Thu, 8 Apr 2021 10:24:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD43161166 for ; Thu, 8 Apr 2021 10:24:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD43161166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lURpo-0004eB-QQ for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 06:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lURos-0003mH-NX for qemu-devel@nongnu.org; Thu, 08 Apr 2021 06:23:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:55772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lURor-0005bf-3R for qemu-devel@nongnu.org; Thu, 08 Apr 2021 06:23:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B9DB1AFF6; Thu, 8 Apr 2021 10:23:23 +0000 (UTC) Subject: Re: [RFC v12 27/65] target/arm: split a15 cpu model and 32bit class functions to cpu32.c To: Richard Henderson , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-28-cfontana@suse.de> From: Claudio Fontana Message-ID: <87e94d27-a1ec-cd6a-8079-0f975121d479@suse.de> Date: Thu, 8 Apr 2021 12:23:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/28/21 6:18 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> provide helper functions there to initialize 32bit models, >> and export the a15 cpu model. >> >> We still need to keep around a15 until we sort out the board configurations. >> >> cpu.c will continue to contain the common parts between >> 32 and 64. >> >> Note that we need to build cpu32 also for TARGET_AARCH64, >> because qemu-system-aarch64 is supposed to be able to run >> non-aarch64 cpus too. >> >> Signed-off-by: Claudio Fontana > > Dump state has nothing to do with a15 or the 32-bit models. The relationship I see here is that 32-bit builds, only really need to use aarch32 version of the dump state, and they do not need to see the aarch64 version. > Moving that should be a separate change. > > The gdbstub changes are also a separate change, afaics. But the main concern is to split more, I understand: will do. > > I don't understand the a15 comment above. Is it really relevant to moving the > 32-bit cpu models? The point there was that we keep around a15 for KVM for the moment, instead of relegating it to the set of "tcg-only" models, so that virt board and qtest continue to function also in the KVM-only build. Mainly for this code here a question from my side: is the current code actually already "wrong"? I mean, we unconditionally set the aarch64-capable cpu classes to all use aarch64_gdb_arch_name and gdbstub64, but what about an aarch64-capable cpu running in 32bit mode? Why don't we have, like tentatively done here for arm_cpu_dump_state, an arm_gdb_arch_name and an arm_cpu_gdb_read_register that check is_a64() and call aaarch32_cpu_gdb_read_register or aarch64_cpu_gdb_read_register accordingly? > > > r~ >