From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50766)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHoD4-0005Ne-Oo
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:17:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHoCy-0000Zb-ST
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:17:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHoCy-0000ZV-Mv
	for qemu-devel@nongnu.org; Tue, 28 Jun 2016 04:17:24 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466777957-5126-1-git-send-email-armbru@redhat.com>
	<1466777957-5126-2-git-send-email-armbru@redhat.com>
	<576D49AA.30906@redhat.com> <87oa6nhv7b.fsf@dusky.pond.sub.org>
	<CAFEAcA9VQK8becbJgA=ZLJ_Pjw2KhTykDezvXWpO+CNhS+vHdA@mail.gmail.com>
Date: Tue, 28 Jun 2016 10:17:22 +0200
In-Reply-To: <CAFEAcA9VQK8becbJgA=ZLJ_Pjw2KhTykDezvXWpO+CNhS+vHdA@mail.gmail.com>
	(Peter Maydell's message of "Mon, 27 Jun 2016 11:07:58 +0100")
Message-ID: <87h9cdenhp.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for
 our own headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 27 June 2016 at 09:50, Markus Armbruster <armbru@redhat.com> wrote:
>> To spice up things, we
>> also name a few of our headers just like system headers we use
>> elsewhere, e.g. "util.h" in net/ vs. <util.h> in util/qemu-openpty.c.
>
> That would be nice to fix at some point I think, it's pretty brittle.
> (We had one issue recently that boiled down to system header vs local
> header confusion, though I forget the details.)

Fixing collisions we're aware of is easy enough, just rename our header.
Finding collisions is more interesting.  Perhaps I can cook up something
for make check-source.