From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D7EC433F5 for ; Mon, 20 Sep 2021 13:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5CDB60F25 for ; Mon, 20 Sep 2021 13:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239618AbhITNtG (ORCPT ); Mon, 20 Sep 2021 09:49:06 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:35758 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236206AbhITNtA (ORCPT ); Mon, 20 Sep 2021 09:49:00 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]:58100) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mSJds-003Ax2-H1; Mon, 20 Sep 2021 07:47:32 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:40164 helo=email.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mSJdr-00F2oS-Ir; Mon, 20 Sep 2021 07:47:32 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Manfred Spraul Cc: LKML , Michal Clapinski , Davidlohr Bueso , Andrew Morton , 1vier1@web.de References: <20210918145337.3369-1-manfred@colorfullife.com> Date: Mon, 20 Sep 2021 08:46:57 -0500 In-Reply-To: <20210918145337.3369-1-manfred@colorfullife.com> (Manfred Spraul's message of "Sat, 18 Sep 2021 16:53:37 +0200") Message-ID: <87ilyv4awe.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mSJdr-00F2oS-Ir;;;mid=<87ilyv4awe.fsf@disp2133>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/Yhyg2VMGs/z48zFTbGq79vNJIwrzD/fU= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] ipc/ipc_sysctl.c: Remove fallback for !CONFIG_PROC_SYSCTL X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Manfred Spraul writes: > Compilation of ipc/ipc_sysctl.c is controlled by > obj-$(CONFIG_SYSVIPC_SYSCTL) > [see ipc/Makefile] > > And CONFIG_SYSVIPC_SYSCTL depends on SYSCTL > [see init/Kconfig] > > An SYSCTL is selected by PROC_SYSCTL. > [see fs/proc/Kconfig] > > Thus: #ifndef CONFIG_PROC_SYSCTL in ipc/ipc_sysctl.c is impossible, the > fallback can be removed. Reviewed-by: "Eric W. Biederman" Eric > Signed-off-by: Manfred Spraul > --- > ipc/ipc_sysctl.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c > index 345e4d673e61..f101c171753f 100644 > --- a/ipc/ipc_sysctl.c > +++ b/ipc/ipc_sysctl.c > @@ -23,7 +23,6 @@ static void *get_ipc(struct ctl_table *table) > return which; > } > > -#ifdef CONFIG_PROC_SYSCTL > static int proc_ipc_dointvec(struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > @@ -118,18 +117,6 @@ static int proc_ipc_dointvec_minmax_checkpoint_restore(struct ctl_table *table, > } > #endif > > -#else > -#define proc_ipc_doulongvec_minmax NULL > -#define proc_ipc_dointvec NULL > -#define proc_ipc_dointvec_minmax NULL > -#define proc_ipc_dointvec_minmax_orphans NULL > -#define proc_ipc_auto_msgmni NULL > -#define proc_ipc_sem_dointvec NULL > -#ifdef CONFIG_CHECKPOINT_RESTORE > -#define proc_ipc_dointvec_minmax_checkpoint_restore NULL > -#endif /* CONFIG_CHECKPOINT_RESTORE */ > -#endif > - > int ipc_mni = IPCMNI; > int ipc_mni_shift = IPCMNI_SHIFT; > int ipc_min_cycle = RADIX_TREE_MAP_SIZE;