From: Kalle Valo <kvalo@codeaurora.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: luciano.coelho@intel.com, linux-wireless@vger.kernel.org,
Ayala Beker <ayala.beker@intel.com>
Subject: Re: [PATCH v2 1/4] iwlwifi: mei: add the driver to allow cooperation with CSME
Date: Tue, 22 Jun 2021 16:28:46 +0300 [thread overview]
Message-ID: <87k0mmjaep.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20210621080159.12883-1-emmanuel.grumbach@intel.com> (Emmanuel Grumbach's message of "Mon, 21 Jun 2021 11:01:56 +0300")
Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
> iwlmei is a driver that handles the communication with the
> Wireless driver of the CSME firmware.
> More details in the documentation included in this patch.
A complicated new feature and just two sentences in the commit log? The
commit log should give a proper overview what the patch does and why.
This commit log really says to the reader "I don't care, find out
yourself".
And being nice I did try to read few paragraphs from the patch but as I
didn't even see any explanation for CSME or SAP I gave up.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-06-22 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 8:01 [PATCH v2 1/4] iwlwifi: mei: add the driver to allow cooperation with CSME Emmanuel Grumbach
2021-06-21 8:01 ` [PATCH v2 2/4] iwlwifi: integrate with iwlmei Emmanuel Grumbach
2021-06-21 11:51 ` kernel test robot
2021-06-21 8:01 ` [PATCH v2 3/4] nl80211: vendor-cmd: add Intel vendor commands for iwlmei usage Emmanuel Grumbach
2021-06-21 8:01 ` [PATCH v2 4/4] iwlwifi: mvm: add vendor commands needed for iwlmei Emmanuel Grumbach
2021-06-22 12:18 ` [PATCH v2 1/4] iwlwifi: mei: add the driver to allow cooperation with CSME Luca Coelho
2021-06-22 14:12 ` Coelho, Luciano
2021-06-22 13:28 ` Kalle Valo [this message]
2021-06-22 13:39 ` Emmanuel Grumbach
2021-06-24 16:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0mmjaep.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ayala.beker@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.