All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/8] drm/i915: dbuf cleanups
Date: Tue, 20 Apr 2021 15:57:45 +0300	[thread overview]
Message-ID: <87mttt9kqe.fsf@intel.com> (raw)
In-Reply-To: <20210416171011.19012-1-ville.syrjala@linux.intel.com>

On Fri, 16 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> A bunch of drive-by-cleanup While I was reading through
> the dbuf code.

Good stuff. On the series,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Some thoughts provoked by the series:

* Time to start splitting up dbuf/ddb/wm stuff from intel_pm.[ch] to
  separate file(s) under display/?

* Time to start moving more display related struct intel_device_info
  fields under the display substruct?

BR,
Jani.


>
> Ville Syrjälä (8):
>   drm/i915: Collect dbuf device info into a sub-struct
>   drm/i915: Handle dbuf bypass path allocation earlier
>   drm/i915: Store dbuf slice mask in device info
>   drm/i915: Use intel_dbuf_slice_size()
>   drm/i915: Use intel_de_rmw() for DBUF_POWER_REQUEST
>   drm/i915: Polish for_each_dbuf_slice()
>   drm/i915: Add enabledisable()
>   drm/i915: Say "enable foo" instead of "set foo to enabled"
>
>  drivers/gpu/drm/i915/display/intel_bw.c       | 11 ++---
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  4 +-
>  drivers/gpu/drm/i915/display/intel_display.h  |  9 ++--
>  .../drm/i915/display/intel_display_power.c    | 24 ++++------
>  drivers/gpu/drm/i915/display/intel_dp.c       | 14 +++---
>  .../drm/i915/display/intel_dp_aux_backlight.c |  2 +-
>  drivers/gpu/drm/i915/display/intel_tc.c       |  4 +-
>  drivers/gpu/drm/i915/i915_pci.c               | 16 +++----
>  drivers/gpu/drm/i915/i915_utils.h             |  5 +++
>  drivers/gpu/drm/i915/intel_device_info.h      |  6 ++-
>  drivers/gpu/drm/i915/intel_pm.c               | 45 +++++++------------
>  drivers/gpu/drm/i915/intel_pm.h               |  1 +
>  12 files changed, 65 insertions(+), 76 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-04-20 12:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 17:10 [Intel-gfx] [PATCH 0/8] drm/i915: dbuf cleanups Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 1/8] drm/i915: Collect dbuf device info into a sub-struct Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 2/8] drm/i915: Handle dbuf bypass path allocation earlier Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 3/8] drm/i915: Store dbuf slice mask in device info Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 4/8] drm/i915: Use intel_dbuf_slice_size() Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 5/8] drm/i915: Use intel_de_rmw() for DBUF_POWER_REQUEST Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 6/8] drm/i915: Polish for_each_dbuf_slice() Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 7/8] drm/i915: Add enabledisable() Ville Syrjala
2021-04-16 17:10 ` [Intel-gfx] [PATCH 8/8] drm/i915: Say "enable foo" instead of "set foo to enabled" Ville Syrjala
2021-04-16 17:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: dbuf cleanups Patchwork
2021-04-16 17:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-04-16 17:30 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-04-16 17:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-16 19:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-20 12:57 ` Jani Nikula [this message]
2021-04-20 13:22   ` [Intel-gfx] [PATCH 0/8] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mttt9kqe.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.