From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, alex.bennee@linaro.org,
qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush()
Date: Wed, 14 Sep 2016 10:39:26 +0530 [thread overview]
Message-ID: <87oa3r2hkp.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1473827823.8689.329.camel@kernel.crashing.org>
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Wed, 2016-09-14 at 09:23 +0530, Nikunj A Dadhania wrote:
>
> Hr... this is confusing, let me rephrase ;-)
>
>> Due to lazy tlb flushes, propagation of the tlb flush is delayed.
> Moreover, certain operations need to do broadcast flush, this too can
> be
>> delayed until we hit the operation that warrant a broadcast.
>
> Instead:
>
> We flush the qemu TLB lazily. check_tlb_flush is called whenever we
> hit a context synchronizing event or instruction that requires a pending
> flush to be performed.
>
> However, we fail to handle broadcast TLB flush operations. In order
> to fix that efficiently, we want to differenciate whether check_tlb_flush()
> needs to only apply pending local flushes (isync instructions,
> interrupts, ...) or also global pending flush operations. The latter
> is only needed when executing instructions that are defined architecturally
> as synchronizing global TLB flush operations. This in our case is ptesync
> on BookS and tlbsync on BookE along with the paravirtualized hypervisor
> calls.
Nice ;-)
Regards
Nikunj
next prev parent reply other threads:[~2016-09-14 5:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 5:48 [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush should have global effect Nikunj A Dadhania
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag Nikunj A Dadhania
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush() Nikunj A Dadhania
2016-09-14 3:09 ` David Gibson
2016-09-14 3:49 ` Benjamin Herrenschmidt
2016-09-14 3:53 ` Nikunj A Dadhania
2016-09-14 4:37 ` Benjamin Herrenschmidt
2016-09-14 5:09 ` Nikunj A Dadhania [this message]
2016-09-14 5:18 ` David Gibson
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect Nikunj A Dadhania
2016-09-12 6:08 ` Benjamin Herrenschmidt
2016-09-12 6:15 ` Nikunj A Dadhania
2016-09-12 6:21 ` Nikunj A Dadhania
2016-09-12 6:05 ` [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush " Benjamin Herrenschmidt
2016-09-12 6:16 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa3r2hkp.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me \
--to=nikunj@linux.vnet.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.