From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 02/22] drm/fb-cma-helper: Use drm_gem_framebuffer_helper Date: Wed, 16 Aug 2017 10:33:19 -0700 Message-ID: <87pobvquxs.fsf@eliezer.anholt.net> References: <1502631125-13557-1-git-send-email-noralf@tronnes.org> <1502631125-13557-3-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1514472001==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 46FFD6E513 for ; Wed, 16 Aug 2017 17:38:21 +0000 (UTC) In-Reply-To: <1502631125-13557-3-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org Cc: narmstrong@baylibre.com, daniel.vetter@ffwll.ch, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, marex@denx.de, boris.brezillon@free-electrons.com, abrodkin@synopsys.com, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, puck.chen@hisilicon.com, jsarha@ti.com, vincent.abriou@st.com, alison.wang@freescale.com, philippe.cornu@st.com, yannick.fertre@st.com, zourongrong@gmail.com, maxime.ripard@free-electrons.com, shawnguo@kernel.org List-Id: dri-devel@lists.freedesktop.org --===============1514472001== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Use the new drm_gem_framebuffer_helper who's code was copied > from this helper. > > Signed-off-by: Noralf Tr=C3=B8nnes > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 181 ++++++------------------------= ------ > 1 file changed, 30 insertions(+), 151 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb= _cma_helper.c > index ade319d..e1befee 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -250,12 +143,14 @@ EXPORT_SYMBOL_GPL(drm_fb_cma_create); > struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct drm_framebuffer= *fb, > unsigned int plane) > { > - struct drm_fb_cma *fb_cma =3D to_fb_cma(fb); > + struct drm_gem_object *gem; >=20=20 > - if (plane >=3D 4) > + gem =3D drm_gem_fb_get_obj(fb, plane); > + if (!gem) > return NULL; >=20=20 > - return fb_cma->obj[plane]; > + return to_drm_gem_cma_obj(gem); > + > } Stray whitespace. Other than that, Reviewed-by: Eric Anholt Feel free to push vc4 and pl111 with this patch. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmUgeAACgkQtdYpNtH8 nuiG5A/+NO83orYnDjmUVNmhVsk2RiAWdzlzR/mlM5m2Eq8g0qT0IL9OQcVH6TFM z1RP+iYN3kvRavFJRhwpdDsePvbckBcgHvom+jVmBKTlr7Zent975mCbsgLCQcSD U3XsA56eBKq8O4nou1Z15s41Lzf6Vqw3vGTqstDSFczD45TVdywGUcdAiiN51cCL eyAPycXEZRW2Qwz4DRe8OXbI6UEslh7NMCh5C1EPiUKv5XEDB0qUTPm2OfTqhJLz nF3rQlIyiXT1aaxq4fAqY0Xj3oY1LHEiGmw2e2Roi0GbVbGtVYJQluSbDSTdly4Y tAcQ6wclMLzzhAsVGauGIT5tzy2WWbvzcR6aplDqnQA2oAvOI+LkxRuR1sLGR9cj EMeK+1q3jH8+k5GpXsmnEg2/WQhHak9XVPEvCQgV/Ht3Lzc/MD/UPNlszZpRmOU9 cSRNnSpNDzVKnTJ0XwxgjafTxfj5qfYZG2EEPOZQKY5GoII8JaFd3AupoMKA3ErT TLe+az906MGM0E90B/UbWyNCjAtldiRe8rDKtE8lTkiW6RfA8FtoBnG5OWqtabf/ DnHmQvTlDgxIV8AB1XzpmLl/KYfNIjKBGzjGzjH6V1VsovG+1TUPYuaMEncRyTbe RkE1yU8K9HsERPuHiHbGBmd6HOobwfzuVMFJObeDruM1hkha5gI= =Gi1l -----END PGP SIGNATURE----- --=-=-=-- --===============1514472001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1514472001==--