From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>,
Sasha Levin <levinsasha928@gmail.com>,
davem@davemloft.net, ericvh@gmail.com, jvrao@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@redhat.com, Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] 9p: disconnect channel when PCI device is removed
Date: Mon, 07 May 2012 12:44:03 +0530 [thread overview]
Message-ID: <87pqagzcn8.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <87397chebf.fsf@rustcorp.com.au>
Rusty Russell <rusty@rustcorp.com.au> writes:
> On Fri, 13 Apr 2012 17:48:36 -0400, Sasha Levin <levinsasha928@gmail.com> wrote:
>> When a virtio_9p pci device is being removed, we should close down any
>> active channels and free up resources, we're not supposed to BUG() if there's
>> still an open channel since it's a valid case when removing the PCI device.
>>
>> Otherwise, removing the PCI device with an open channel would cause the
>> following BUG():
>
> (Damn changed notmuch.el bindings! Previous reply went only to Sasha).
>
> Applied thanks,
> Rusty.
I am not sure whether the patch is sufficient, p9_virtio_remove does a
kfree(chan) and since we are not doing anything at the file system
level, we would still allow new 9p client request. That means
p9_virtio_request would be dereferencing a freed memory.
-aneesh
prev parent reply other threads:[~2012-05-07 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 21:48 [PATCH] 9p: disconnect channel when PCI device is removed Sasha Levin
2012-04-15 12:27 ` Aneesh Kumar K.V
2012-04-16 4:35 ` Sasha Levin
2012-04-16 10:59 ` Aneesh Kumar K.V
2012-04-28 8:55 ` Sasha Levin
2012-04-28 18:16 ` Aneesh Kumar K.V
2012-04-29 3:21 ` Sasha Levin
2012-05-07 3:15 ` Rusty Russell
2012-05-07 7:14 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqagzcn8.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.