From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FC2C636C9 for ; Sat, 17 Jul 2021 10:59:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1419613BB for ; Sat, 17 Jul 2021 10:59:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1419613BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4i2O-0004sN-H8 for qemu-devel@archiver.kernel.org; Sat, 17 Jul 2021 06:59:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4i1a-000438-Ar for qemu-devel@nongnu.org; Sat, 17 Jul 2021 06:58:26 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4i1Y-0005jV-MO for qemu-devel@nongnu.org; Sat, 17 Jul 2021 06:58:25 -0400 Received: by mail-wr1-x436.google.com with SMTP id g16so15077376wrw.5 for ; Sat, 17 Jul 2021 03:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=bsPOLzggftSkWNLi3rMdG52Pcf1gwQbp6I8ahH++Oik=; b=LjJHg3g44jFDBzEJH5M99ile0sRUtcUgH7CLK1qWgquTN49CMGS7er14cfVOpBkkGO 12C/XIiSEQp9xjfx/YYBWxCIlo9Kl4baT4ZdVP7q38L7bPtPD4g6q/oL4M7etgEHej7t XSr3oWSxyC+NYpj9FYCRlRugCEXAwg3uJ8re/S5eXbZsvY9mbhDrlxseHx1anWu7K16M NLLP1z1pA2YZFVDZLXfiVF1OQtamtmqPtleshhx8CzEB4oMIO/N0uitY41hBs9QYLnLC KWiRvscND3W0Pyri5023tgb8M3ODt8+dRWVLdxyfT0ZIvgpqMkca7Yn7YeNp1WxR4Gmc Yryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=bsPOLzggftSkWNLi3rMdG52Pcf1gwQbp6I8ahH++Oik=; b=bOPfUkfbLI2ukY+KQn0uhJvOq+qG9oejgUcxA97ij6cb0+GMdjsckoVHycBn6tutA3 D3XS6CORU5hEukreSskwI+0vR/22TcLk+eSz2wSBOkW8XL8Y9mgBZVoJdv7q/Lwnxf50 MMcZEcZFDQI9OFzrAaVwvTff/SzjpFHTRnkvpSNdrqq2wWhPu2oqM3n31U174ff0a8Lw hUdDD7JzggOWqYICyBNw4JuzZiMY1h1v5tXDgF3bmfdext4ZZw8lMlse9RvqD7w7C0JC Lh5/oS9hDkT5cEXjhnpUMAudCuy77ruSiL/LBQvh+wbHI2KQnZ+aXY7avs51LP+CEZ3j lAHg== X-Gm-Message-State: AOAM532hkRA64a8pY5wT6SmmCPl6CxVAlEG6y8RgTvNjduCts+D+jves 0NfERY9ClCwm64JinjYdYiPPnQ== X-Google-Smtp-Source: ABdhPJyM5h2tziZ393P61Yin+Ref10EHisdCla1Nz1N9xppIulm+dHll5v7V0HJbgTXN93fzHN8kqw== X-Received: by 2002:a5d:5403:: with SMTP id g3mr17763024wrv.403.1626519501768; Sat, 17 Jul 2021 03:58:21 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id l2sm9497346wms.21.2021.07.17.03.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jul 2021 03:58:19 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F37E01FF7E; Sat, 17 Jul 2021 11:58:18 +0100 (BST) References: <20210717103017.20491-1-peter.maydell@linaro.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Subject: Re: [PATCH] target/hexagon: Drop include of qemu.h Date: Sat, 17 Jul 2021 11:58:05 +0100 In-reply-to: <20210717103017.20491-1-peter.maydell@linaro.org> Message-ID: <87r1fx2omt.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taylor Simpson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on > the include path for softmmu builds. Currently we include it > unconditionally in target/hexagon/op_helper.c. We used to need it > for the put_user_*() and get_user_*() functions, but now that we have > removed the uses of those from op_helper.c, the only reason it's > still there is that we're implicitly relying on it pulling in some > other headers. > > Explicitly include the headers we need for other functions, and drop > the include of qemu.h. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e