From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23991C47092 for ; Tue, 1 Jun 2021 10:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06725613AD for ; Tue, 1 Jun 2021 10:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233627AbhFAK1U (ORCPT ); Tue, 1 Jun 2021 06:27:20 -0400 Received: from foss.arm.com ([217.140.110.172]:46460 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbhFAK1S (ORCPT ); Tue, 1 Jun 2021 06:27:18 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1164311FB; Tue, 1 Jun 2021 03:25:37 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 269123F73D; Tue, 1 Jun 2021 03:25:36 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent() In-Reply-To: <87y2c0s748.wl-maz@kernel.org> References: <20210525173255.620606-1-valentin.schneider@arm.com> <20210525173255.620606-9-valentin.schneider@arm.com> <87y2c0s748.wl-maz@kernel.org> Date: Tue, 01 Jun 2021 11:25:33 +0100 Message-ID: <87r1hlg9uq.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/21 13:17, Marc Zyngier wrote: > On Tue, 25 May 2021 18:32:53 +0100, > Valentin Schneider wrote: >> o make irq_chip_ack_parent() the default chip->irq_ack() via >> MSI_FLAG_USE_DEF_CHIP_OPS. > > Seem like a reasonable approach: how about a custom irq_ack() callback > that iterates over the hierarchy until it finds an a non-NULL entry? > Flows that don't use ack won't be impacted, users that need ack will > provide one if they want, and the default will do something slightly > slower, but at least unsurprising. > Sounds about right! >> XXX: what about pMSI and fMSI ? > > Same thing. They are just bus-specific domains on top of the ITS > domain, and must follow the same convention. > > However, this patch is perfectly acceptable to me (as long as you take > care of platform and fsl -MSI). > Noted. > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F95DC4708F for ; Tue, 1 Jun 2021 10:28:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CF276124B for ; Tue, 1 Jun 2021 10:28:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CF276124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k1ZoGxFYDmZS7zdP8vp4/3sN/EPNnalNHyRHpLQPSx8=; b=FXa/46Hhoh4czW q7cx8zZVC8yRQ0FfU/ASidNdwwOEdBCtqWN7eNT1Wq9aiMsX8jldmSW1Vtf+4/gdYJDuAsxhtdqbY pNx/+b6sLEZtlKlsOeb6jCJWAIQxVEl3bkeIga9GHbYOafL/Sm+R0f2nRYwE6rEIJbHLNvis99PDd 2nnKiH3Bh5nhMW/myZXm8cruiT9uFSem0E4AIdBL7I72ADxKnDIqnS6oLaBc+AkccZV9KRCVTkpNV nLdxtB4ZKuefNAbT3SFSLHhyOot4pasdBKU6FAzuH7jYHfhyF0lhlILGEIdeIhjzzIgsVf//hlEnz PbArzgyqih6XVK+hgxlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1cG-00Fv46-RC; Tue, 01 Jun 2021 10:27:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1ah-00Fu9a-BN for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 10:25:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1164311FB; Tue, 1 Jun 2021 03:25:37 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 269123F73D; Tue, 1 Jun 2021 03:25:36 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH v2 08/10] irqchip/gic-v3-its: Use irq_chip_ack_parent() In-Reply-To: <87y2c0s748.wl-maz@kernel.org> References: <20210525173255.620606-1-valentin.schneider@arm.com> <20210525173255.620606-9-valentin.schneider@arm.com> <87y2c0s748.wl-maz@kernel.org> Date: Tue, 01 Jun 2021 11:25:33 +0100 Message-ID: <87r1hlg9uq.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_032543_466233_5AE77353 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/05/21 13:17, Marc Zyngier wrote: > On Tue, 25 May 2021 18:32:53 +0100, > Valentin Schneider wrote: >> o make irq_chip_ack_parent() the default chip->irq_ack() via >> MSI_FLAG_USE_DEF_CHIP_OPS. > > Seem like a reasonable approach: how about a custom irq_ack() callback > that iterates over the hierarchy until it finds an a non-NULL entry? > Flows that don't use ack won't be impacted, users that need ack will > provide one if they want, and the default will do something slightly > slower, but at least unsurprising. > Sounds about right! >> XXX: what about pMSI and fMSI ? > > Same thing. They are just bus-specific domains on top of the ITS > domain, and must follow the same convention. > > However, this patch is perfectly acceptable to me (as long as you take > care of platform and fsl -MSI). > Noted. > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel