From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381B7C63697 for ; Tue, 24 Nov 2020 00:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB82C20758 for ; Tue, 24 Nov 2020 00:22:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="GnsHHxDV"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="R5Nrqf5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729220AbgKXAWT (ORCPT ); Mon, 23 Nov 2020 19:22:19 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:39356 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729147AbgKXAWS (ORCPT ); Mon, 23 Nov 2020 19:22:18 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606177336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lNWG1qtA7G9hsXhDsP3MLyuLVDI6XyrC+5IMdQxT6I=; b=GnsHHxDVlgVk9jhbfel6mUdbSJviiStSsYo8URmgtLjUwigsSaEnFEZVczVC9zmZx9bLsk qw25m4y6TgB1ZeXycueSktHBq26BiSEIvCd2KSJIoAvJiEbG6erl60+Ikvl4P4XcIy4V0N SD4BOfGbwXB6RLWXYfnoEzY4AGhaI5VpFBZJ+7omzKLIh5fuZOgox/raDnxgXngOdEAcWS +23U8DIcpeANt0FBdY2n2RikNrgGZKGfW5V43WqEoyVKjm8IW1Mudr6JsWItXH+rf71ZRo mlFudGebOnhpdGuFgMzmhzdimfucYMEkIW1zOzBhZax23CJRM7IiSnLdkDEDjQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606177336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lNWG1qtA7G9hsXhDsP3MLyuLVDI6XyrC+5IMdQxT6I=; b=R5Nrqf5gfiZGYJaIxbHMfpdUIrkuH70SVcO+mrIvTHKAoADJPzDVJZb2ure/dUCXkzLuEJ gYnuVRoafusac5DA== To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Paul McKenney , Sebastian Andrzej Siewior , Arnd Bergmann , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Russell King , Marc Zyngier , Valentin Schneider , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon Subject: Re: [patch 14/19] softirq: Make softirq control and processing RT aware In-Reply-To: <20201124001350.GF1751@lothringen> References: <20201113140207.499353218@linutronix.de> <20201113141734.324061522@linutronix.de> <20201123134437.GA95787@lothringen> <87r1ojnaai.fsf@nanos.tec.linutronix.de> <20201123235801.GE1751@lothringen> <87wnyblitk.fsf@nanos.tec.linutronix.de> <20201124001350.GF1751@lothringen> Date: Tue, 24 Nov 2020 01:22:16 +0100 Message-ID: <87r1ojli2v.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Frederic, On Tue, Nov 24 2020 at 01:13, Frederic Weisbecker wrote: > On Tue, Nov 24, 2020 at 01:06:15AM +0100, Thomas Gleixner wrote: >> Good point. Haven't thought about that. Let me have a look again. > > But I'm cooking a patchset which moves account_irq_enter_time() after > HARDIRQ_OFFSET or SOFTIRQ_OFFSET is incremented. This will allow us to move > tick_irq_enter() under this layout: > > preempt_count_add(HARDIRQ_OFFSET) > lockdep_hardirq_enter() > tick_irq_enter() > account_irq_enter_time() > > This way tick_irq_enter() can be correctly handled by lockdep and we can remove > the nasty hack which temporarily disables softirqs around it. > > And as a side effect it should also fix your issue. > > I should have that ready soonish. Sounds to good to be true :) Looking forward to it! Thanks for taking care of that! tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2041C56202 for ; Tue, 24 Nov 2020 00:22:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7956020757 for ; Tue, 24 Nov 2020 00:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XH4KzS4i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="GnsHHxDV"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="R5Nrqf5g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7956020757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AW812WLilr93gkRBjz8LTA8+KfKqraWWdpVBpbw0dHg=; b=XH4KzS4ibbcVE144NoMu6NV/x iPVLbuUcUk8hgJcNtJy4weZ2eHFk10OaNk7hI6IVsobCbd+kXx83UQEmCw813KkK7qlsitsBWjyqg 2+1p0+jXXAjBi6BehBe8Ept2aFT7vyDmyGdkNMz1RSZ4Z+E2b33y6iG3QU39CWx3fMkndaK6CSkrq Px30cw9ulliqu8uwM9f5unujGEp7KXU5ax56XnlubJ1mrr0q4ffixGs5VjOMg8mFL3qA8xjHLYCfF hfXzVoX1O5K/NLyQcpHmEUCk1U0utHUJ1tqus7R8KdJTbQWOS4VJluSLxuEEpT0RLqGb5gbA0gSgH d9HX7fXLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khM69-0002Fz-1w; Tue, 24 Nov 2020 00:22:21 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khM66-0002FB-6M; Tue, 24 Nov 2020 00:22:19 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606177336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lNWG1qtA7G9hsXhDsP3MLyuLVDI6XyrC+5IMdQxT6I=; b=GnsHHxDVlgVk9jhbfel6mUdbSJviiStSsYo8URmgtLjUwigsSaEnFEZVczVC9zmZx9bLsk qw25m4y6TgB1ZeXycueSktHBq26BiSEIvCd2KSJIoAvJiEbG6erl60+Ikvl4P4XcIy4V0N SD4BOfGbwXB6RLWXYfnoEzY4AGhaI5VpFBZJ+7omzKLIh5fuZOgox/raDnxgXngOdEAcWS +23U8DIcpeANt0FBdY2n2RikNrgGZKGfW5V43WqEoyVKjm8IW1Mudr6JsWItXH+rf71ZRo mlFudGebOnhpdGuFgMzmhzdimfucYMEkIW1zOzBhZax23CJRM7IiSnLdkDEDjQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606177336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lNWG1qtA7G9hsXhDsP3MLyuLVDI6XyrC+5IMdQxT6I=; b=R5Nrqf5gfiZGYJaIxbHMfpdUIrkuH70SVcO+mrIvTHKAoADJPzDVJZb2ure/dUCXkzLuEJ gYnuVRoafusac5DA== To: Frederic Weisbecker Subject: Re: [patch 14/19] softirq: Make softirq control and processing RT aware In-Reply-To: <20201124001350.GF1751@lothringen> References: <20201113140207.499353218@linutronix.de> <20201113141734.324061522@linutronix.de> <20201123134437.GA95787@lothringen> <87r1ojnaai.fsf@nanos.tec.linutronix.de> <20201123235801.GE1751@lothringen> <87wnyblitk.fsf@nanos.tec.linutronix.de> <20201124001350.GF1751@lothringen> Date: Tue, 24 Nov 2020 01:22:16 +0100 Message-ID: <87r1ojli2v.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_192218_395495_7B56F82E X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Catalin Marinas , Paul McKenney , Arnd Bergmann , linux-sh@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Sebastian Andrzej Siewior , Valentin Schneider , Jeff Dike , LKML , Yoshinori Sato , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Marc Zyngier , Russell King , linux-um@lists.infradead.org, Will Deacon , Helge Deller , linux-arm-kernel@lists.infradead.org, Anton Ivanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Frederic, On Tue, Nov 24 2020 at 01:13, Frederic Weisbecker wrote: > On Tue, Nov 24, 2020 at 01:06:15AM +0100, Thomas Gleixner wrote: >> Good point. Haven't thought about that. Let me have a look again. > > But I'm cooking a patchset which moves account_irq_enter_time() after > HARDIRQ_OFFSET or SOFTIRQ_OFFSET is incremented. This will allow us to move > tick_irq_enter() under this layout: > > preempt_count_add(HARDIRQ_OFFSET) > lockdep_hardirq_enter() > tick_irq_enter() > account_irq_enter_time() > > This way tick_irq_enter() can be correctly handled by lockdep and we can remove > the nasty hack which temporarily disables softirqs around it. > > And as a side effect it should also fix your issue. > > I should have that ready soonish. Sounds to good to be true :) Looking forward to it! Thanks for taking care of that! tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Thomas Gleixner Subject: Re: [patch 14/19] softirq: Make softirq control and processing RT aware In-Reply-To: <20201124001350.GF1751@lothringen> References: <20201113140207.499353218@linutronix.de> <20201113141734.324061522@linutronix.de> <20201123134437.GA95787@lothringen> <87r1ojnaai.fsf@nanos.tec.linutronix.de> <20201123235801.GE1751@lothringen> <87wnyblitk.fsf@nanos.tec.linutronix.de> <20201124001350.GF1751@lothringen> Date: Tue, 24 Nov 2020 01:22:16 +0100 Message-ID: <87r1ojli2v.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Frederic Weisbecker Cc: Rich Felker , Catalin Marinas , Paul McKenney , Arnd Bergmann , linux-sh@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Sebastian Andrzej Siewior , Valentin Schneider , Jeff Dike , LKML , Yoshinori Sato , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Marc Zyngier , Russell King , linux-um@lists.infradead.org, Will Deacon , Helge Deller , linux-arm-kernel@lists.infradead.org, Anton Ivanov Frederic, On Tue, Nov 24 2020 at 01:13, Frederic Weisbecker wrote: > On Tue, Nov 24, 2020 at 01:06:15AM +0100, Thomas Gleixner wrote: >> Good point. Haven't thought about that. Let me have a look again. > > But I'm cooking a patchset which moves account_irq_enter_time() after > HARDIRQ_OFFSET or SOFTIRQ_OFFSET is incremented. This will allow us to move > tick_irq_enter() under this layout: > > preempt_count_add(HARDIRQ_OFFSET) > lockdep_hardirq_enter() > tick_irq_enter() > account_irq_enter_time() > > This way tick_irq_enter() can be correctly handled by lockdep and we can remove > the nasty hack which temporarily disables softirqs around it. > > And as a side effect it should also fix your issue. > > I should have that ready soonish. Sounds to good to be true :) Looking forward to it! Thanks for taking care of that! tglx _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um