From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsvAJ-0005T9-8q for qemu-devel@nongnu.org; Thu, 14 May 2015 11:35:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsvAE-0005qL-9y for qemu-devel@nongnu.org; Thu, 14 May 2015 11:35:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsvAE-0005qA-5a for qemu-devel@nongnu.org; Thu, 14 May 2015 11:35:10 -0400 From: Markus Armbruster References: <1431607862-9238-1-git-send-email-eblake@redhat.com> <1431607862-9238-9-git-send-email-eblake@redhat.com> Date: Thu, 14 May 2015 17:35:07 +0200 In-Reply-To: <1431607862-9238-9-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 14 May 2015 06:50:54 -0600") Message-ID: <87r3qjw4t0.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 08/16] qapi: Tidy c_type logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > c_type() is designed to be called on both string names and on > array designations, so 'name' is a bit misleading because it > operates on more than strings. Also, no caller ever passes > an empty string. Finally, + notation is a bit nicer to read > than '%s' % value for string concatenation. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster