From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF97C433F5 for ; Tue, 14 Sep 2021 05:51:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 380BD610A6 for ; Tue, 14 Sep 2021 05:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 380BD610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ1Lu-0004UK-At for qemu-devel@archiver.kernel.org; Tue, 14 Sep 2021 01:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ1Kl-0003j2-QM for qemu-devel@nongnu.org; Tue, 14 Sep 2021 01:50:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ1Kk-0003Jo-61 for qemu-devel@nongnu.org; Tue, 14 Sep 2021 01:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631598617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n3xt2U/mf1TV0ivlW1YU85QayL6/GsS0/xbD4PCXqKI=; b=AiXqblbhhkDJRtQfLWRA8u7Gq5/uBK7O934UcdgbIB+beoVwIe9V5WnATBkNJyJSFBV1gy V18jb0+5vs/wnIx56MFGpwcKWRv3cR+Iqebr3gtO14peVgvulGqwNT8C5wL10JhYLhfvFF PdDOEcc6dWgLZBllWYG1ndXoUvjd294= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-tKDfVl3lNryUhSLu7Smfag-1; Tue, 14 Sep 2021 01:50:16 -0400 X-MC-Unique: tKDfVl3lNryUhSLu7Smfag-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E58C362F8 for ; Tue, 14 Sep 2021 05:50:15 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0C0E19724; Tue, 14 Sep 2021 05:50:11 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2A16A113865F; Tue, 14 Sep 2021 07:50:10 +0200 (CEST) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH 12/22] test-qobject-input-visitor: Wean off UserDefListUnion References: <20210913123932.3306639-1-armbru@redhat.com> <20210913123932.3306639-13-armbru@redhat.com> <20210913150609.hr4fm3uqyqd4vlz5@redhat.com> Date: Tue, 14 Sep 2021 07:50:10 +0200 In-Reply-To: <20210913150609.hr4fm3uqyqd4vlz5@redhat.com> (Eric Blake's message of "Mon, 13 Sep 2021 10:06:09 -0500") Message-ID: <87sfy7g0z1.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On Mon, Sep 13, 2021 at 02:39:22PM +0200, Markus Armbruster wrote: >> The test_visitor_in_list_union_FOO() use simple union UserDefListUnion >> to cover lists of builtin types. Rewrite as >> test_visitor_in_list_struct(), using struct ArrayStruct and a lot less >> code. >> >> test_visitor_in_fail_union_list() uses UserDefListUnion to cover >> "variant members don't match the discriminator value". Cover that in >> test_visitor_in_fail_union_flat() instead, and drop >> test_visitor_in_fail_union_list(). Appropriating the former for this >> purpose is okay, because it actually failed due to missing >> discriminator, which is still covered by >> test_visitor_in_fail_union_flat_no_discrim(). >> >> Signed-off-by: Markus Armbruster >> --- >> tests/unit/test-qobject-input-visitor.c | 460 ++++++++---------------- >> 1 file changed, 148 insertions(+), 312 deletions(-) >> >> @@ -1206,7 +1066,7 @@ static void test_visitor_in_fail_union_flat(TestInputVisitorData *data, >> Error *err = NULL; >> Visitor *v; >> >> - v = visitor_input_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }"); >> + v = visitor_input_test_init(data, "{ 'enum1': 'value2', 'string': 'c', 'integer': 41, 'boolean': true }"); > > Long line; do we care? We have loads of similar lines in unit tests, and I've given up on them. > Reviewed-by: Eric Blake Thanks!