From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65526C47080 for ; Tue, 1 Jun 2021 10:25:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 420BF613AB for ; Tue, 1 Jun 2021 10:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbhFAK1M (ORCPT ); Tue, 1 Jun 2021 06:27:12 -0400 Received: from foss.arm.com ([217.140.110.172]:46448 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbhFAK1J (ORCPT ); Tue, 1 Jun 2021 06:27:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D42C11FB; Tue, 1 Jun 2021 03:25:28 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85E023F73D; Tue, 1 Jun 2021 03:25:27 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH v2 02/10] genirq: Define irq_ack() and irq_eoi() helpers In-Reply-To: <871r9stpd5.wl-maz@kernel.org> References: <20210525173255.620606-1-valentin.schneider@arm.com> <20210525173255.620606-3-valentin.schneider@arm.com> <8735u8tphl.wl-maz@kernel.org> <871r9stpd5.wl-maz@kernel.org> Date: Tue, 01 Jun 2021 11:25:25 +0100 Message-ID: <87sg21g9uy.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/21 11:58, Marc Zyngier wrote: > On Thu, 27 May 2021 11:55:50 +0100, > Marc Zyngier wrote: >> >> On Tue, 25 May 2021 18:32:47 +0100, >> Valentin Schneider wrote: >> > diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h >> > index b6c1cceddec0..090bd7868845 100644 >> > --- a/kernel/irq/internals.h >> > +++ b/kernel/irq/internals.h >> > @@ -87,6 +87,8 @@ extern void irq_enable(struct irq_desc *desc); >> > extern void irq_disable(struct irq_desc *desc); >> > extern void irq_percpu_enable(struct irq_desc *desc, unsigned int cpu); >> > extern void irq_percpu_disable(struct irq_desc *desc, unsigned int cpu); >> > +extern void irq_ack(struct irq_desc *desc); >> > +extern void irq_eoi(struct irq_desc *desc); >> >> Nit: we have {un,}mask_irq, but you add irq_{ack,eoi}. It'd be good to >> have some naming consistency (yes, this may/will clash with existing >> code, but we can fix that as well). > > Actually, the helpers do have the right naming, but the internal > declarations are the ones that are wrong... > Doh! > M. > > -- > Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382A6C47080 for ; Tue, 1 Jun 2021 10:28:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0D0E6124B for ; Tue, 1 Jun 2021 10:28:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0D0E6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BNGf6zQ/TDdz74UQh847LOsvxTARPvJ+JIkIJPfs6dw=; b=vpA5Kt2aCqEIN5 UgZkHqimvnkvIrmqR07SdRAVUutnD5YICoYGrtBojrD/Y0nbUuWBB1BMcDmbYy/4C/WHgHHrloBuI 4N046GtHE/ZxCJKperLj1pMbOLkI2u/qb2m+4HI+jpVH/+QMA+GogsKoY9Bpy+XAhxatIzThrzKc6 E6Kw4KzGG/qtbQAktkaI8tx2+vckJjjVr+aSgStdFPkTAsBgHRWe/JIIlU2W+H56MNRykwMfHrA5K Zeo/ryuFKzvqjIws5J1O0xKKHNcXtOL7ED26lkW/sDepy+afHLLKSVyu40ENvIWhnIqLtDQWiiwn0 a4RrK57ViQy2grrH6NFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1be-00FuhX-Uq; Tue, 01 Jun 2021 10:26:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1aT-00Fu3q-Pk for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 10:25:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D42C11FB; Tue, 1 Jun 2021 03:25:28 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85E023F73D; Tue, 1 Jun 2021 03:25:27 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH v2 02/10] genirq: Define irq_ack() and irq_eoi() helpers In-Reply-To: <871r9stpd5.wl-maz@kernel.org> References: <20210525173255.620606-1-valentin.schneider@arm.com> <20210525173255.620606-3-valentin.schneider@arm.com> <8735u8tphl.wl-maz@kernel.org> <871r9stpd5.wl-maz@kernel.org> Date: Tue, 01 Jun 2021 11:25:25 +0100 Message-ID: <87sg21g9uy.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_032529_911713_634416D9 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/05/21 11:58, Marc Zyngier wrote: > On Thu, 27 May 2021 11:55:50 +0100, > Marc Zyngier wrote: >> >> On Tue, 25 May 2021 18:32:47 +0100, >> Valentin Schneider wrote: >> > diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h >> > index b6c1cceddec0..090bd7868845 100644 >> > --- a/kernel/irq/internals.h >> > +++ b/kernel/irq/internals.h >> > @@ -87,6 +87,8 @@ extern void irq_enable(struct irq_desc *desc); >> > extern void irq_disable(struct irq_desc *desc); >> > extern void irq_percpu_enable(struct irq_desc *desc, unsigned int cpu); >> > extern void irq_percpu_disable(struct irq_desc *desc, unsigned int cpu); >> > +extern void irq_ack(struct irq_desc *desc); >> > +extern void irq_eoi(struct irq_desc *desc); >> >> Nit: we have {un,}mask_irq, but you add irq_{ack,eoi}. It'd be good to >> have some naming consistency (yes, this may/will clash with existing >> code, but we can fix that as well). > > Actually, the helpers do have the right naming, but the internal > declarations are the ones that are wrong... > Doh! > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel