From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: make-wifi-fast@lists.bufferbloat.net,
Felix Fietkau <nbd@nbd.name>,
Rajkumar Manoharan <rmanohar@codeaurora.org>,
Kan Yan <kyan@google.com>, Yibo Zhao <yiboz@codeaurora.org>
Subject: Re: [PATCH mac80211-next v8] mac80211: Switch to a virtual time-based airtime scheduler
Date: Wed, 23 Jun 2021 11:27:16 +0200 [thread overview]
Message-ID: <87tulpnd6z.fsf@toke.dk> (raw)
In-Reply-To: <e1798568decc6df9b44ce97f48be523bdc92bdc4.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Fri, 2021-05-07 at 11:48 +0200, Toke Høiland-Jørgensen wrote:
>> This switches the airtime scheduler in mac80211 to use a virtual time-based
>
> Generally, we prefer <=72 columns in commit messages ... I started
> reformatting, but then your code also has a lot of places that go over
> 80 columns, so I gave up ... Can you please do that?
I thought the new limit was 100? :)
But sure, I can take a look and remove the unnecessary ones...
> Some refactoring, e.g. in sta_apply_parameters(), may also be in order.
Will take a look!
-Toke
prev parent reply other threads:[~2021-06-23 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:48 [PATCH mac80211-next v8] mac80211: Switch to a virtual time-based airtime scheduler Toke Høiland-Jørgensen
2021-06-22 14:25 ` Toke Høiland-Jørgensen
2021-06-23 9:14 ` Johannes Berg
2021-06-23 9:27 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tulpnd6z.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.