Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

[Markus Armbruster <armbru@redhat.com>]

Peter Xu <peterx@redhat.com> writes:

> On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote:
>> From: Fei Li <shirley17fei@gmail.com>
>> 
>> Let's supplement the msi_uninit() when failing to realize
>> the pci edu device.
>> 
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Peter Xu <peterx@redhat.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
>> Signed-off-by: Fei Li <shirley17fei@gmail.com>
>> ---
>>  hw/misc/edu.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
>> index cdcf550dd7..4feb7503de 100644
>> --- a/hw/misc/edu.c
>> +++ b/hw/misc/edu.c
>> @@ -367,6 +367,7 @@ static void pci_edu_uninit(PCIDevice *pdev)
>>  {
>>      EduState *edu = EDU(pdev);
>>  
>> +    msi_uninit(pdev);
>
> It would be cleaner to me to call this after the join() since
> edu_fact_thread() could potentially use msi_*() helpers then the
> destructions follow the reverse order of init.

Destruction in reverse creation order is good practice.

This being the "QEMU educational PCI device", good practice is even more
desirable.

> Reviewed-by: Peter Xu <peterx@redhat.com>
>
>>      qemu_mutex_lock(&edu->thr_mutex);
>>      edu->stopping = true;
>>      qemu_mutex_unlock(&edu->thr_mutex);
>> -- 
>> 2.17.2 (Apple Git-113)
>> 
>
> Regards,