From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH v5 4/4] migration: handle the error condition properly Date: Mon, 03 Sep 2018 19:28:34 +0200 Message-ID: <87wos21oe5.fsf@trasno.org> References: <20180903092644.25812-1-xiaoguangrong@tencent.com> <20180903092644.25812-5-xiaoguangrong@tencent.com> Reply-To: quintela@redhat.com Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, Xiao Guangrong , dgilbert@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org, wei.w.wang@intel.com, jiang.biao2@zte.com.cn, pbonzini@redhat.com To: guangrong.xiao@gmail.com Return-path: In-Reply-To: <20180903092644.25812-5-xiaoguangrong@tencent.com> (guangrong xiao's message of "Mon, 3 Sep 2018 17:26:44 +0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org guangrong.xiao@gmail.com wrote: > From: Xiao Guangrong > > ram_find_and_save_block() can return negative if any error hanppens, > however, it is completely ignored in current code > > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela Good catch. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwseb-00084s-40 for qemu-devel@nongnu.org; Mon, 03 Sep 2018 13:28:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwseY-00032z-1l for qemu-devel@nongnu.org; Mon, 03 Sep 2018 13:28:45 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43516 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fwseX-00032m-Th for qemu-devel@nongnu.org; Mon, 03 Sep 2018 13:28:41 -0400 From: Juan Quintela In-Reply-To: <20180903092644.25812-5-xiaoguangrong@tencent.com> (guangrong xiao's message of "Mon, 3 Sep 2018 17:26:44 +0800") References: <20180903092644.25812-1-xiaoguangrong@tencent.com> <20180903092644.25812-5-xiaoguangrong@tencent.com> Reply-To: quintela@redhat.com Date: Mon, 03 Sep 2018 19:28:34 +0200 Message-ID: <87wos21oe5.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 4/4] migration: handle the error condition properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: guangrong.xiao@gmail.com Cc: pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, dgilbert@redhat.com, peterx@redhat.com, wei.w.wang@intel.com, jiang.biao2@zte.com.cn, eblake@redhat.com, Xiao Guangrong guangrong.xiao@gmail.com wrote: > From: Xiao Guangrong > > ram_find_and_save_block() can return negative if any error hanppens, > however, it is completely ignored in current code > > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela Good catch.