From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8E-00048o-TX
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8C-0001MU-UZ
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bHQ8C-0001MP-PJ
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:34:52 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466777957-5126-1-git-send-email-armbru@redhat.com>
	<1466777957-5126-3-git-send-email-armbru@redhat.com>
	<CAFEAcA-S+VBrmjoZx0KX2ngGVjiY_a+eFiM0O4tBEL7khVjxLg@mail.gmail.com>
Date: Mon, 27 Jun 2016 08:34:50 +0200
In-Reply-To: <CAFEAcA-S+VBrmjoZx0KX2ngGVjiY_a+eFiM0O4tBEL7khVjxLg@mail.gmail.com>
	(Peter Maydell's message of "Fri, 24 Jun 2016 15:23:05 +0100")
Message-ID: <87wplbb0mt.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 24 June 2016 at 15:19, Markus Armbruster <armbru@redhat.com> wrote:
>> For now, this tests just a bit of header sanity: for each header
>> "FOO.h", test whether
>>
>>         #include "qemu/osdep.h"
>>         #include "FOO.h"
>>         #include "FOO.h"
>>
>> compiles.  A large number of headers don't pass this test, by design
>> or by accident.  These are all excluded for now.  Excluded headers
>> contain a comment
>>
>>     /* FIXME Does not pass make check-headers, yet! */
>>
>> Many headers fail the test only with CONFIG_WIN32.  These contain a
>> comment
>>
>>     /* FIXME Does not pass make check-headers with CONFIG_WIN32, yet! */
>>
>> Add make target check-excluded-headers to help with examining how they
>> fail.
>>
>> These tests work only in a git tree, with git installed.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>>  disas/libvixl/vixl/a64/assembler-a64.h    |  2 ++
>>  disas/libvixl/vixl/a64/constants-a64.h    |  2 ++
>>  disas/libvixl/vixl/a64/cpu-a64.h          |  2 ++
>>  disas/libvixl/vixl/a64/decoder-a64.h      |  2 ++
>>  disas/libvixl/vixl/a64/disasm-a64.h       |  2 ++
>>  disas/libvixl/vixl/a64/instructions-a64.h |  2 ++
>>  disas/libvixl/vixl/code-buffer.h          |  2 ++
>>  disas/libvixl/vixl/compiler-intrinsics.h  |  2 ++
>>  disas/libvixl/vixl/globals.h              |  2 ++
>>  disas/libvixl/vixl/invalset.h             |  2 ++
>>  disas/libvixl/vixl/platform.h             |  2 ++
>>  disas/libvixl/vixl/utils.h                |  2 ++
>
> This is third-party code. We're not going to change it, so
> we should avoid scanning it rather than adding tags which
> will get lost next time we do an update to a new upstream
> version...

I can revive v1's blacklist for this directory.  Any others?