All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
Subject: Re: [PATCH 1/3] ALSA: add snd_card_disconnect_sync()
Date: Wed, 11 Oct 2017 07:51:31 +0000	[thread overview]
Message-ID: <87zi8ynn8b.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <s5hfuaqi1f5.wl-tiwai@suse.de>


Hi Takashi

> > Takashi-san
> > 
> > I created this patch and its git-log, but please fixup it
> > if needed.
> 
> I would split this again to two patches, one for adding
> snd_card_disconnect_sync(), and another for adding snd_pcm_stop() call
> at snd_pcm_dev_disconnect().
> 
> Basically the latter is for the drivers that don't handle the PCM stop
> at disconnection explicitly, and it's not mandatory when the driver's
> pcm dev_disconnect callback handles it.
> 
> Also, since these changes are about ALSA core, and at least the
> PCM-stop one is intrusive and may have influences on the behavior of
> other drivers, I'd like to test with usb-audio before landing to ASoC
> world.  Once when confirmed, I'll publish a persistent branch
> containing these API changes and let Mark pull it.

Thanks.
I will re-post [2/3] [3/3] part patch on top of your persistent branch.

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2017-10-11  7:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11  6:33 [PATCH 0/3] ALSA: add snd_card_disconnect_sync() Kuninori Morimoto
2017-10-11  6:36 ` [PATCH 1/3] " Kuninori Morimoto
2017-10-11  7:33   ` Takashi Iwai
2017-10-11  7:51     ` Kuninori Morimoto [this message]
2017-10-11  6:37 ` [PATCH 2/3] ASoC: add snd_soc_card_disconnect_sync() Kuninori Morimoto
2017-10-11  8:42   ` Mark Brown
2017-10-11  8:47     ` Kuninori Morimoto
2017-10-11  6:37 ` [PATCH 3/3] ASoC: rsnd: call snd_soc_card_disconnect_sync() when remove Kuninori Morimoto
2017-10-11  6:56   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi8ynn8b.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=horms@verge.net.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.