All of lore.kernel.org
 help / color / mirror / Atom feed
From: stillcompiling@gmail.com
To: Anatolij Gustschin <agust@denx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Tull <atull@kernel.org>,
	linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org,
	Moritz Fischer <moritz.fischer@ettus.com>,
	delicious.quinoa@gmail.com,
	Joshua Clayton <stillcompiling@gmail.com>
Subject: Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date: Fri, 09 Jun 2017 15:07:54 -0700	[thread overview]
Message-ID: <88068505.BWkoHaDEJR@jclayton-pc> (raw)
In-Reply-To: <20170609151840.2ea43706@crub>

On Friday, June 9, 2017 3:18:40 PM PDT Anatolij Gustschin wrote:
> On Fri, 9 Jun 2017 11:51:12 +0200
> Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
> ...
> 
> >I get the following build error with this patch:
> >
> >ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined!
> 
> it is due to enabled COMPILE_TEST and disabled CONFIG_SPI.
> 
> >So I'll just ignore this whole series, can you fix these issues up and
> >resend?
> 
> would "depends on SPI || (COMPILE_TEST && SPI)" in Kconfig be a proper
> fix for this? Anyone an idea?
> 

> Thanks,
> Anatolij
I don't think that ends up being any different than "depends on SPI"
But, it is an SPI slave driver driver, after all.
COMPILE_TEST is intended to build stuff that can't work due to a lack of 
hardware support, or lack of crosscompiler.
"selects SPI" would work, but is discouraged.

I just built successfully on native x86_64 with no problem, by enabling SPI.
"depends on SPI" is the right thing here.
I'm not sure when || COMPILE_TEST sneaked in there.

I'll submit a v13 with that small change.
-- 
~Joshua A Clayton

  reply	other threads:[~2017-06-09 22:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 19:07 [PATCH 00/10] patches for fpga Alan Tull
2017-06-05 19:07 ` [PATCH 01/10] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Alan Tull
2017-06-05 19:07 ` [PATCH 02/10] Make FPGA a menuconfig to ease disabling it all Alan Tull
2017-06-05 19:07 ` [PATCH 03/10] fpga: allow to compile-test Altera FPGA bridge drivers Alan Tull
2017-06-06 13:45   ` kbuild test robot
2017-06-09  9:49   ` Greg Kroah-Hartman
2017-06-09 13:44     ` Tobias Klauser
2017-06-10  3:55       ` Alan Tull
2017-06-05 19:07 ` [PATCH 04/10] fpga: Add flag to indicate SPI bitstream is bit-reversed Alan Tull
2017-06-05 19:07 ` [PATCH 05/10] doc: dt: document altera-passive-serial binding Alan Tull
2017-06-05 19:07 ` [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs Alan Tull
2017-06-09  9:51   ` Greg Kroah-Hartman
2017-06-09 13:18     ` Anatolij Gustschin
2017-06-09 22:07       ` stillcompiling [this message]
2017-06-10 14:43     ` Alan Tull
2017-06-05 19:07 ` [PATCH 07/10] ARM: dts: imx6q-evi: support altera-ps-spi Alan Tull
2017-06-05 19:07 ` [PATCH 08/10] lib: add bitrev8x4() Alan Tull
2017-06-05 19:07 ` [PATCH 09/10] fpga-manager: altera-ps-spi: use bitrev8x4 Alan Tull
2017-06-05 19:07 ` [PATCH 10/10] of: Add vendor prefix for Lattice Semiconductor Alan Tull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88068505.BWkoHaDEJR@jclayton-pc \
    --to=stillcompiling@gmail.com \
    --cc=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=delicious.quinoa@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moritz.fischer@ettus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.