All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erwan Velu <evelu@redhat.com>
To: ceph-devel <ceph-devel@vger.kernel.org>
Subject: About ceph_clock_now()
Date: Tue, 12 Jan 2016 10:59:53 -0500 (EST)	[thread overview]
Message-ID: <892700092.10054838.1452614393452.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <177186823.10053087.1452614184109.JavaMail.zimbra@redhat.com>

Hi folks,

When reading the code I noticed that ceph_clock_now() is mostly used to compute a local difference of time.
I do see you are using "clock_gettime(CLOCK_REALTIME, &tp)" but was wondering if CLOCK_MONOTONIC_RAW isn't more accurate.

I mean if the local system time is readujsted by NTP (or similar) some computation could be wrong leading to some possible mis-interpretation or wrong scheduling.

Any thoughts on that ?

I could work on a PR is you find this interesting.

Cheers,
Erwan

       reply	other threads:[~2016-01-12 15:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <177186823.10053087.1452614184109.JavaMail.zimbra@redhat.com>
2016-01-12 15:59 ` Erwan Velu [this message]
2016-01-12 17:32   ` About ceph_clock_now() Adam C. Emerson
2016-01-13 10:41     ` Erwan Velu
2016-01-13 13:48       ` Sage Weil
2016-01-13 14:52         ` Matt Benjamin
2016-01-14 16:10         ` Erwan Velu
2016-01-14 16:14           ` Adam C. Emerson
2016-01-19 16:17         ` Erwan Velu
2016-01-19 16:29           ` Adam C. Emerson
2016-01-19 16:57             ` Erwan Velu
2016-01-21 19:22             ` Erwan Velu
2016-01-22 16:00               ` Erwan Velu
2016-01-22 17:35                 ` Adam C. Emerson
2016-01-26 14:12                   ` Erwan Velu
2016-01-23 11:49                 ` Willem Jan Withagen
2016-01-23 20:20                   ` Matt Benjamin
2016-01-23 21:55                     ` Adam C. Emerson
2016-01-24 11:53                       ` Willem Jan Withagen
2016-01-24 12:51                         ` Willem Jan Withagen
2016-01-25  0:03                           ` Adam C. Emerson
2016-01-25  9:08                             ` Willem Jan Withagen
2016-01-25  9:58                               ` Erwan Velu
2016-01-25 10:57                                 ` Willem Jan Withagen
2016-01-25 17:22                                   ` Adam C. Emerson
     [not found]                                     ` <56A66099.4030501@digiware.nl>
     [not found]                                       ` <1523354716.24670379.1453744826329.JavaMail.zimbra@redhat.com>
2016-01-25 19:38                                         ` Willem Jan Withagen
2016-01-25 20:14                                           ` Adam C. Emerson
2016-01-25 20:18                                             ` Matt Benjamin
2016-01-25 20:22                                             ` Willem Jan Withagen
2016-01-13 15:28       ` Adam C. Emerson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=892700092.10054838.1452614393452.JavaMail.zimbra@redhat.com \
    --to=evelu@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.