All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	"Theodore Y . Ts'o" <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Michael Halcrow <mhalcrow@google.com>,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] fscrypt: add a documentation file for filesystem-level encryption
Date: Fri, 18 Aug 2017 15:06:52 -0600	[thread overview]
Message-ID: <8EA94C5A-A3F7-48BC-91BE-3C0BD17D7927@dilger.ca> (raw)
In-Reply-To: <20170818194730.61575-1-ebiggers3@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On Aug 18, 2017, at 1:47 PM, Eric Biggers <ebiggers3@gmail.com> wrote:
> +Key hierarchy
> +=============
> +
> +Master Keys
> +-----------
> +
> +Userspace should generate master keys either using a cryptographically
> +secure random number generator, e.g. by reading from ``/dev/urandom``
> +or calling getrandom(), or by using a KDF (Key Derivation Function).
> +Note that whenever a KDF is used to "stretch" a lower-entropy secret
> +such as a passphrase, it is critical that a KDF designed for this
> +purpose be used, such as scrypt, PBKDF2, or Argon2.

One minor suggestion - when generating a master key for a filesystem,
I'd think it is preferable to use /dev/random instead of /dev/urandom
to ensure there is enough entropy.

Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2017-08-18 21:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 19:47 [PATCH] fscrypt: add a documentation file for filesystem-level encryption Eric Biggers
2017-08-18 21:06 ` Andreas Dilger [this message]
2017-08-20  2:32   ` Theodore Ts'o
2017-08-21 22:33     ` Eric Biggers
2017-08-21 13:44 ` Anand Jain
2017-08-21 21:02   ` Theodore Ts'o
2017-08-21 23:08   ` Eric Biggers
2017-08-22  2:22     ` Anand Jain
2017-08-22  3:07       ` Eric Biggers
2017-08-22 15:35         ` Anand Jain
2017-08-22 17:36           ` Eric Biggers
2017-08-28 12:18             ` Anand Jain
2017-08-31 18:14               ` Eric Biggers
2017-08-22  3:07       ` Theodore Ts'o
2017-08-22  2:22 ` Anand Jain
2017-08-22  2:55   ` Eric Biggers
2017-08-22 15:33     ` Anand Jain
2017-08-22 17:07       ` Eric Biggers
2017-08-28 12:18         ` Anand Jain
2017-08-28 14:22           ` Theodore Ts'o
2017-08-29  3:54             ` Anand Jain
2017-08-31 18:10               ` Eric Biggers
2017-08-31 17:50           ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8EA94C5A-A3F7-48BC-91BE-3C0BD17D7927@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mhalcrow@google.com \
    --cc=richard@nod.at \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.