From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA2BC43143 for ; Thu, 21 Jun 2018 22:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F60622514 for ; Thu, 21 Jun 2018 22:50:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F60622514 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934071AbeFUWuT (ORCPT ); Thu, 21 Jun 2018 18:50:19 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:40553 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933878AbeFUWuS (ORCPT ); Thu, 21 Jun 2018 18:50:18 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01353;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0T37v2II_1529621398; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0T37v2II_1529621398) by smtp.aliyun-inc.com(127.0.0.1); Fri, 22 Jun 2018 06:50:01 +0800 Subject: Re: [PATCH] mm: thp: register mm for khugepaged when merging vma for shmem From: Yang Shi To: "Kirill A. Shutemov" Cc: hughd@google.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1529617247-126312-1-git-send-email-yang.shi@linux.alibaba.com> <20180621221008.r33hpd223kx2gv3a@kshutemo-mobl1> Message-ID: <8a411d2f-1765-beb2-0850-73feaa7ba79b@linux.alibaba.com> Date: Thu, 21 Jun 2018 15:49:58 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/21/18 3:24 PM, Yang Shi wrote: > > > On 6/21/18 3:10 PM, Kirill A. Shutemov wrote: >> On Fri, Jun 22, 2018 at 05:40:47AM +0800, Yang Shi wrote: >>> When merging anonymous page vma, if the size of vam can fit in at least >> s/vam/vma/ >> >>> one hugepage, the mm will be registered for khugepaged for collapsing >>> THP in the future. >>> >>> But, it skips shmem vma. Doing so for shmem too when merging vma in >>> order to increase the odd to collapse hugepage by khugepaged. >> Good catch. Thanks. >> >> I think the fix incomplete. We shouldn't require vma->anon_vma for >> shmem, >> only for anonymous mappings. We don't support file-private THPs. > > So you mean, shmem_file(vma->vm_file) && PageAnon(page)? I got your point. Please disregard the question. > >> >>> Also increase the count of shmem THP collapse. It looks missed before. >> Separate patch, please. > > Sure. > > Thanks, > Yang > >> >