From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020AbcKUKau (ORCPT ); Mon, 21 Nov 2016 05:30:50 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61529 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbcKUKar (ORCPT ); Mon, 21 Nov 2016 05:30:47 -0500 X-AuditID: cbfec7f1-f79f46d0000008eb-11-5832ccd39924 Subject: Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage To: Krzysztof Kozlowski Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Lars-Peter Clausen From: Sylwester Nawrocki Message-id: <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> Date: Mon, 21 Nov 2016 11:30:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-version: 1.0 In-reply-to: <1479669895-19124-3-git-send-email-krzk@kernel.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRmVeSWpSXmKPExsWy7djPc7qXzxhFGDzeJm9x5eIhJoupD5+w WZw/v4HdYsnk+awW3650MFlsenyN1eLyrjlsFjPO72Oy6NzVz2pxccUXJosN39cyOnB7bPjc xOaxc9Zddo9NqzrZPDYvqfdY8uYQq8e+t8vYPPq2rGL0WL/lKovH501yAZxRXDYpqTmZZalF +nYJXBktP4+yFqxlrzh42rCB8T9rFyMnh4SAicTKL6dZIGwxiQv31rN1MXJxCAksZZQ4/PYD lPOZUeLi26fMMB3TX/xngUgsY5ToXt7DDpIQEnjOKPFymgKILSyQJnGn+SwjiC0ioClx/e93 VpAGZoH7TBLfT18DS7AJGEr0Hu0Ds3kF7CS2Nn8AG8QioCpxd+1vNhBbVCBC4uDG1VA1ghI/ Jt8Du5VTwEHi+/dFYBcxCxhIzJhymAnClpfYvOYtM8gyCYFH7BKtXYuBEhxAjqzEpgNQH7hI 9K76CPW/sMSr41vYIWwZic6Og0wQvf2MEifWNDNCODMYJe60T2CCqLKWOHz8IivENj6JSdum M0Ms4JXoaBOCKPGQmPzvLFS5o8Sz8y+YICF0klHi+363CYzys5D8MwvJD7OQ/LCAkXkVo0hq aXFuemqxkV5xYm5xaV66XnJ+7iZGYHo6/e/4xx2M709YHWIU4GBU4uFtWGkUIcSaWFZcmXuI UYKDWUmE985poBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHePQuuhAsJpCeWpGanphakFsFkmTg4 pRoYj8Ts9mG6LRF697L94l0CR9XnrBSU1a34kZGqI1TV9OzSa64/c3zm6LdrK/QazA+/+Ezo FCOzz751K99fDrfh/u69/oitjsX5/6UHZWwupWRKGq6v32i8fFdE+7TC4Mb+Z0UczSbRto3V m6add+NXu314soz1plnhpScmWiv8Sr1d02Hc0XxViaU4I9FQi7moOBEA4UKfVUsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t/xK7p3zhhFGOw6amZx5eIhJoupD5+w WZw/v4HdYsnk+awW3650MFlsenyN1eLyrjlsFjPO72Oy6NzVz2pxccUXJosN39cyOnB7bPjc xOaxc9Zddo9NqzrZPDYvqfdY8uYQq8e+t8vYPPq2rGL0WL/lKovH501yAZxRbjYZqYkpqUUK qXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMto+XmU tWAte8XB04YNjP9Zuxg5OSQETCSmv/jPAmGLSVy4t56ti5GLQ0hgCaPE5Fl72UESQgLPGSX2 rAQrEhZIk+iddZIJxBYR0JS4/vc7K0TDSUaJGTOmsIA4zAL3mSQary8GW8EmYCjRe7SPEcTm FbCT2Nr8AWwqi4CqxN21v9lAbFGBCIlNX+ewQNQISvyYfA/M5hRwkPj+fRFzFyMH0FA9ifsX tUDCzALyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUSS0tzk3PLTbUK07MLS7NS9dLzs/dxAiM 023Hfm7ewXhpY/AhRgEORiUe3oaVRhFCrIllxZW5hxglOJiVRHgXnAYK8aYkVlalFuXHF5Xm pBYfYjQFemEis5Rocj4wheSVxBuaGJpbGhoZW1iYGxkpifOWfLgSLiSQnliSmp2aWpBaBNPH xMEp1cBY0RP+vezt1VlN7snpcV4+ZgWdbJllEt33Y5I3um7WfBqbuOXsoXPbNifJXFEyu5P/ sXvfzwknylddDlabsaHw3LqlqbFxdu730oxU7DYsPLr6UwrPrqxHiQYNWSzTFOXUQtbrJa4X MNH2OfNwksnKtDsZbgck27/Y3Jld+vh10bJtGZXN0b5KLMUZiYZazEXFiQBO302c6QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161121103043eucas1p1ad816feb2bfbc602f3354464791afacb X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161120192523epcas1p4f764b20d525d28059b85373276a4f725 X-RootMTR: 20161120192523epcas1p4f764b20d525d28059b85373276a4f725 References: <1479669895-19124-1-git-send-email-krzk@kernel.org> <1479669895-19124-3-git-send-email-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: > MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported > so we can drop the dead code. After this the driver no longer > differentiates between machines (S3C24xx machines are not supported by > it) so there is no need to override I2S device id in cpu_dai_name and > SEC_PLAYBACK dai_link can be removed as well. > > Signed-off-by: Krzysztof Kozlowski > --- > > Not tested. The driver did not override .platform_name which looks > suspicious to me. However I did not want to add changes which could have > some visible impact on output code. The patch looks good to me. However the existing smdk64xx sound support less so. I don't have smdk6410 set up for testing yet, possibly I get around that next week. Indeed it's strange .platform_name is not also "samsung-i2s.2". Reviewed-by: Sylwester Nawrocki From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Mon, 21 Nov 2016 11:30:41 +0100 Subject: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage In-Reply-To: <1479669895-19124-3-git-send-email-krzk@kernel.org> References: <1479669895-19124-1-git-send-email-krzk@kernel.org> <1479669895-19124-3-git-send-email-krzk@kernel.org> Message-ID: <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: > MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported > so we can drop the dead code. After this the driver no longer > differentiates between machines (S3C24xx machines are not supported by > it) so there is no need to override I2S device id in cpu_dai_name and > SEC_PLAYBACK dai_link can be removed as well. > > Signed-off-by: Krzysztof Kozlowski > --- > > Not tested. The driver did not override .platform_name which looks > suspicious to me. However I did not want to add changes which could have > some visible impact on output code. The patch looks good to me. However the existing smdk64xx sound support less so. I don't have smdk6410 set up for testing yet, possibly I get around that next week. Indeed it's strange .platform_name is not also "samsung-i2s.2". Reviewed-by: Sylwester Nawrocki