Re: [PATCH v2 - AAF PCM plugin 0/7] Introduce AVTP Audio Format (AAF) plugin

[Jaroslav Kysela <perex@perex.cz>]

Dne 25.10.2018 v 03:11 Andre Guedes napsal(a):
> Hi all,
> 
> This new version addresses the feedback from v1 and fixes a bug on capture
> mode. Code-wise, the changes are very trivial, no major diffs. Below follows
> the highlights:
> 
>   * Standard headers like linux/if_ether.h are now checked by configure script.
>   * The 'static' modifier was added to array variables in aaf_hw_constraint().
>   * aaf_close() callback was simplified.
>   * aaf_rx_pdu() was modified so it doesn't return an error in case the number
>     of bytes read by recv() is different from aaf->pdu_size. This is an
>     expected situation and it means the received AVTPDU doesn't belong to the
>     AAF stream the plugin is interested in so it should simply drop that
>     AVTPDU. This fixes a bug when running multiple streams (with different
>     AVPTU sizes) concurrently.
> 
> Additionally, this new version improves the instructions in doc/aaf.txt in
> order to make it easier to test the plugin. Anyone should be able to test it
> just by copying and pasting the instructions.

Thanks for your code. I did a quick review and a compilation test and it
seems fine to include this improved code to alsa-plugins. I committed
your changes.

Our repos are on github now, too : https://github.com/alsa-project

						Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.