From: "Cédric Le Goater" <clg@kaod.org>
To: Thomas Huth <thuth@redhat.com>, <qemu-ppc@nongnu.org>,
<qemu-devel@nongnu.org>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address
Date: Thu, 2 Dec 2021 20:19:40 +0100 [thread overview]
Message-ID: <8d21273b-0b81-5041-cfc4-704307aa37cc@kaod.org> (raw)
In-Reply-To: <d8119266-e6f1-969c-d440-d511951178f6@redhat.com>
On 12/2/21 20:17, Thomas Huth wrote:
> On 02/12/2021 20.14, Cédric Le Goater wrote:
>> The default addresses to load the kernel, fdt, initrd of AMCC boards
>> in U-Boot v2015.10 are :
>>
>> "kernel_addr_r=1000000\0"
>> "fdt_addr_r=1800000\0"
>> "ramdisk_addr_r=1900000\0"
>>
>> The taihu is one of these boards, the ref405ep is not but we don't
>> have much information on it and both boards have a very similar
>> address space layout. Change the kernel load address to match U-Boot
>> expectations and fix loading.
>
> You could additionally mention that U-Boot corrupts the kernel if it gets loaded to address 0.
True. The first word is overwritten with zeros. I looked for it
in the code but could not find the reason.
Thanks,
C.
>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> hw/ppc/ppc405_boards.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
>> index 972a7a4a3e5d..b4249f4626e6 100644
>> --- a/hw/ppc/ppc405_boards.c
>> +++ b/hw/ppc/ppc405_boards.c
>> @@ -45,7 +45,7 @@
>> #define BIOS_FILENAME "ppc405_rom.bin"
>> #define BIOS_SIZE (2 * MiB)
>> -#define KERNEL_LOAD_ADDR 0x00000000
>> +#define KERNEL_LOAD_ADDR 0x01000000
>> #define INITRD_LOAD_ADDR 0x01800000
>> #define USE_FLASH_BIOS
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
next prev parent reply other threads:[~2021-12-02 19:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 19:14 [PATCH] hw/ppc/ppc405_boards: Change kernel load address Cédric Le Goater
2021-12-02 19:17 ` Thomas Huth
2021-12-02 19:19 ` Cédric Le Goater [this message]
2021-12-02 19:32 ` LEROY Christophe
2021-12-03 10:27 ` Cédric Le Goater
2021-12-03 10:31 ` Thomas Huth
2021-12-03 10:40 ` Peter Maydell
2021-12-03 12:25 ` Cédric Le Goater
2021-12-08 13:07 ` Thomas Huth
2021-12-08 13:15 ` Cédric Le Goater
2021-12-08 13:19 ` Thomas Huth
2021-12-08 16:54 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d21273b-0b81-5041-cfc4-704307aa37cc@kaod.org \
--to=clg@kaod.org \
--cc=christophe.leroy@c-s.fr \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.