From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lWMaZ-0002AQ-Gb for mharc-grub-devel@gnu.org; Tue, 13 Apr 2021 13:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWMaX-00026u-VZ for grub-devel@gnu.org; Tue, 13 Apr 2021 13:12:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWMaW-0002ic-7X for grub-devel@gnu.org; Tue, 13 Apr 2021 13:12:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618333951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ErgodU1W3kybreNdebItbtEvAozRS8aZN2L7EWVEX7w=; b=K72fSkVBgSIJDR7XNESzvUOxOx3ejM42Yc9a2EMgn3OwpsxRRwK/8MDR9/IHC35AScOTT2 4452yvDFUyGOTsVi8UqDpnlv9Gt8KcjcTdr6lmR/VUrOSTwVUTtgsiFyBPXKlQPRrTTcbl +P9StFEh+0sG9jZoc08g/Laue0+G0aQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-MUCUozOvM0CCAnAcUIs-xg-1; Tue, 13 Apr 2021 13:12:29 -0400 X-MC-Unique: MUCUozOvM0CCAnAcUIs-xg-1 Received: by mail-wm1-f70.google.com with SMTP id i14-20020a05600c354eb029010c9426f34aso3221866wmq.3 for ; Tue, 13 Apr 2021 10:12:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ErgodU1W3kybreNdebItbtEvAozRS8aZN2L7EWVEX7w=; b=HZJc+AIUo2WEPXGHIvGoNrMTvi0yRPROlCjGuv6af/GaqLWl4TwU06dxUXr81f1aBG t1LlDmEHhbqWHl8gjLa0+Ar1hKZ6cMJkj9sLYwd4bolP2fmENRRlJKbmpXOPAY0maYtb sCx7W5Wgz/8Yv8E1dFu92TRyivjaUKql4RQvY+Kj49y0MtfeNYEAUN8HfMgJyPdOww5H Efi1Wp63LceUFASChhSNgwhsLRe89bNAJ4T3lGAHcrNsi1aKqTOPVtNqy/6DYlSrI/WN DDjJ14QMHZEjPQHI5De88v6zi03DzeMroLEryRHVNpU2w9US+1yUQ+RfT+ZQdY/dNEa8 v8Iw== X-Gm-Message-State: AOAM531rWRQz8cFx/m67OAG5CMq6KdzPaRVH2biTuaqTFoN6rcm2RB7B B7Zu2SEqXXt0ELuVFBVrczb757eHytRe4ESuS5FtWvbeC/PCzya3qBHQ2A8daqA6x/Rm176LXxY LDRlWJBGoy2w= X-Received: by 2002:a5d:6e06:: with SMTP id h6mr8205565wrz.201.1618333947429; Tue, 13 Apr 2021 10:12:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFqOeNvKQbaoEwmIo7yCgagg/0R5Yy/XiGIrLSycCF1YE0u+JsGNf7Y06S4zKGa0GxwUKGFg== X-Received: by 2002:a5d:6e06:: with SMTP id h6mr8205549wrz.201.1618333947261; Tue, 13 Apr 2021 10:12:27 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id s64sm3073125wmf.2.2021.04.13.10.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 10:12:26 -0700 (PDT) Subject: Re: [PATCH 1/2] Add bigtime support for xfs driver To: Carlos Maiolino , grub-devel@gnu.org Cc: daniel.kiper@oracle.com References: <20210323132959.1594989-1-cmaiolino@redhat.com> <20210323132959.1594989-2-cmaiolino@redhat.com> From: Javier Martinez Canillas Message-ID: <8dc09b75-bd64-fa74-1216-9484457975dd@redhat.com> Date: Tue, 13 Apr 2021 19:12:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323132959.1594989-2-cmaiolino@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=javierm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 17:12:34 -0000 Hello Carlos, Please add a "fs/xfs:" prefix to your subject line. On 3/23/21 2:29 PM, Carlos Maiolino wrote: > XFS filesystem now supports bigtime feature, to overcome y2038 problem. > This patch makes grub able to support xfs filesystems with this feature > enabled. > > xfs counter for bigtime enable timestamps starts on 0, which translates > to INT32_MIN (Dec 31 20:45:52 UTC 1901) in the legacy timestamps. The > conversion to unix timestamps is made before passing the value to > grub-core. > > For this to work properly, grub requires to access flags2 field in the > xfs ondisk inode, so, the grub_xfs_inode structure has been updated to > the full ondisk inode size. > > This patch is enough to make grub work properly with files with > timestamps up to INT32_MAX (y2038), any file with timestamps bigger than > this will overflow the counter, causing grub to show wrong timestamps > (not really much difference on current situation). > > Signed-off-by: Carlos Maiolino Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat