From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Dumazet' <edumazet@google.com>, David Lebrun <dlebrun@google.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next 2/2] net: optimize skb_postpull_rcsum()
Date: Fri, 3 Dec 2021 17:41:36 +0000 [thread overview]
Message-ID: <8ebf0214bdef4c50bff5ae19171e8e53@AcuMS.aculab.com> (raw)
In-Reply-To: <CANn89i+sANhK4m_JptWgnjXf5VRuSYw6MkLKfS3ut5SbUbrmoQ@mail.gmail.com>
...
> > There are also 40 csum_partial(buf, len, 0).
> > If all the buffer is zero they'll return zero - invalid.
> > They ought to be changed to csum_partial(buf, len, 0xffff).
> >
>
> Please point where all zero buffers can be valid in the first place.
They probably can't be.
But I bet a lot of the code was written without realising it mattered.
A quick scan does imply that they are all probably ok.
But I have spotted 18 ~csum_fold() - they may be dubious.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-12-03 17:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 20:24 [PATCH net-next 0/2] net: small csum optimizations Eric Dumazet
2021-11-24 20:24 ` [PATCH net-next 1/2] gro: optimize skb_gro_postpull_rcsum() Eric Dumazet
2021-11-24 20:24 ` [PATCH net-next 2/2] net: optimize skb_postpull_rcsum() Eric Dumazet
2021-11-25 9:41 ` David Laight
2021-11-25 13:32 ` Eric Dumazet
2021-11-25 14:29 ` David Laight
2021-12-02 13:10 ` Vladimir Oltean
2021-12-02 14:51 ` Eric Dumazet
2021-12-02 16:29 ` Vladimir Oltean
2021-12-02 19:32 ` Eric Dumazet
2021-12-02 20:37 ` Eric Dumazet
2021-12-02 21:07 ` Vladimir Oltean
2021-12-02 20:40 ` Vladimir Oltean
2021-12-02 20:58 ` Vladimir Oltean
2021-12-02 20:58 ` David Laight
2021-12-02 21:40 ` Vladimir Oltean
2021-12-03 14:51 ` David Laight
2021-12-03 14:57 ` David Laight
2021-12-03 16:14 ` Vladimir Oltean
2021-12-03 16:30 ` Eric Dumazet
2021-12-03 16:47 ` David Laight
2021-12-03 16:58 ` Eric Dumazet
2021-12-03 17:41 ` David Laight [this message]
2021-12-02 15:06 ` David Laight
2021-12-02 15:22 ` Eric Dumazet
2021-11-26 5:20 ` [PATCH net-next 0/2] net: small csum optimizations patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ebf0214bdef4c50bff5ae19171e8e53@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=dlebrun@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.