From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C247C636CA for ; Sat, 17 Jul 2021 12:13:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F401613C0 for ; Sat, 17 Jul 2021 12:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F401613C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=On0fRO0xCoPAtHyDVB6P12nzRcPXN/AGSylosslNEHE=; b=1Ahcu1bEJtc+2mBLzmEou6l2Pr UWiS8YsPAzCcRg9CO4TtkTcknRT+s5mRp4rwAx/6EoUjhQz1kIgnzEh2QZ6swg87PAEocyud/AKqa qfeDBtNhKkh+elgDduz+aogp5DrFCZqTbU41qTE6LOznnNTnItsY/Hq/uuxroHdenQgf9eBLN9Jay eAPvPlWJFNG93Nc2fo19U9w5RAP30OgoghmAjwDulMwc6LNHz5rq5P9m9Njjy/EKtbxtXztcH7KVY /ggtwo0GwYlAKfA2+/XteAE5qEhAPg5Aih0E8nyQtF7575xJF9Y7+J9GdlDASAt1/5XyyIRjKHXZn NCljo9pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4jAO-006Zcs-Or; Sat, 17 Jul 2021 12:11:36 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4jAL-006ZcA-Lp for linux-arm-kernel@lists.infradead.org; Sat, 17 Jul 2021 12:11:35 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A8FB08022F; Sat, 17 Jul 2021 14:11:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626523892; bh=7+QEvi1nw/tPFzZhEjwYvhl86xGukHS8d+4/lLDYCqY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VUEy4sUfbxnhtmvBmp6JTbSw13aJpqOVMaCtoO0oEwZtbC4CuLOk7dEEgK+ASoVZY VSLOrYMI4hEl58ML8VxyR2MkoE6fTL1RFfKRDvZviaKJC0VR25lY+h4KzkJ6Kax/Pv t0eRQuSnMgA8ABQKHcBkTi4hWStlR3oxCAhwlCIGCGgzfUdJVGjV1xAcg4fWa9M+eZ ccJf9aMibghG3QJvW6wfWTN2erojQ6WZ+e7eDZ8Br8IG3DTy1mDXUU7o74Mn/D9szb /vaaTHLtpWkwaQ2oK2TA/0Pi+IPzSfT/PS04vXc/JOw84HHPpE4rG2oUEGpiMswLnl sKgSHMkdN1jUQ== Subject: Re: [PATCH] soc: imx: gpcv2: Assert reset before ungating clock To: Lucas Stach , linux-arm-kernel@lists.infradead.org Cc: ch@denx.de, Fabio Estevam , Frieder Schrempf , NXP Linux Team , Peng Fan , Shawn Guo References: <20210630225902.237192-1-marex@denx.de> <7685e3da21367e66057592fc003392abb0674dda.camel@pengutronix.de> From: Marek Vasut Message-ID: <8fa08def-af38-33eb-7505-c8077db9f548@denx.de> Date: Sat, 17 Jul 2021 14:07:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210717_051133_924610_696E0AC7 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/17/21 11:07 AM, Lucas Stach wrote: > Am Samstag, dem 17.07.2021 um 02:55 +0200 schrieb Marek Vasut: >> On 7/17/21 1:32 AM, Lucas Stach wrote: >>> Hi Marek, >> >> Hi, >> >>> Am Donnerstag, dem 01.07.2021 um 00:59 +0200 schrieb Marek Vasut: >>>> In case the power domain clock are ungated before the reset is asserted, >>>> the system might freeze completely. However, the MX8MM GPUMIX and VPUMIX >>>> domains require different reset deassertion timing, and incorrect reset >>>> deassertion timing also leads to hang. >>>> >>>> Add per-domain reset_{,de}assert_early flags which allow fine-grained >>>> control of the reset assertion and deassertion sequence. Currently, on >>>> MX8MM, the behavior is as follows and aligned with NXP downstream ATF >>>> fork: >>>> - VPUMIX: reset assert, reset deassert, domain power up >>>> - GPUMIX: reset assert, domain power on, reset deassert >>>> >>> This patch should now be necessary, as my testing over the last few >>> days showed that the VPUMIX isn't actually different and copes just >>> fine with the reset being asserted early, just like the GPUMIX domain. >> >> Yes, this patch is absolutely essential, otherwise the system hangs at >> random, as explained in the commit message. > > And I was tired. This should have read *not* be necessary. Please take > a look at the series I posted, where I just reverted the patch which > changed the reset order to a late reset. With this the GPC now once > again uses the reset order as required by the GPU, without any > additional complexity. During my extensive testing in the last few months, I've noticed random hangs of the platform and the reset/clock enablement order does matter, and it is different for different domains. The code in NXP ATF fork seems to confirm that. Why do you think that is not the case , is there some documentation which confirms your hypothesis ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel