On 3/23/21 7:47 PM, Greg KH wrote: > On Wed, Mar 17, 2021 at 05:50:22PM +0800, kernel test robot wrote: >> Hi Manish, >> >> Thank you for the patch! Perhaps something to improve: >> >> [auto build test WARNING on usb/usb-testing] >> [also build test WARNING on robh/for-next v5.12-rc3 next-20210316] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Manish-Narani/Add-a-separate-DWC3-OF-driver-for-Xilinx-platforms/20210317-145425 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing >> config: arm64-allyesconfig (attached as .config) >> compiler: aarch64-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/0day-ci/linux/commit/def409fdf931cd77f4a88812570ea6f38f4053d8 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Manish-Narani/Add-a-separate-DWC3-OF-driver-for-Xilinx-platforms/20210317-145425 >> git checkout def409fdf931cd77f4a88812570ea6f38f4053d8 >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >>>> drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead >> >> vim +27 drivers/usb/dwc3/dwc3-xilinx.c >> >> 25 >> 26 /* USB phy reset mask register */ >> > 27 #define XLNX_USB_PHY_RST_EN 0x001C >> 28 #define XLNX_PHY_RST_MASK 0x1 >> 29 > I do not understand this warning message. What is it trying to say? Hi Greg, It's a kernel-doc warning: $ ./scripts/kernel-doc -none drivers/usb/dwc3/dwc3-xilinx.c drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead the root cause is that there's a redundant symbol ( * ) at the beginning: diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index a59e1494b1a0..f42f4cbffab0 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -1,5 +1,5 @@  // SPDX-License-Identifier: GPL-2.0 -/** +/*   * dwc3-xilinx.c - Xilinx DWC3 controller specific glue driver   *   * Authors: Manish Narani Best Regards, Rong Chen > > confused, > > greg k-h >