On Thu, 09 Sep 2010 00:52:17 +0200, David Härdeman <david@hardeman.nu> wrote:
> This patch enables the sending of AVI infoframes in
> drivers/gpu/drm/i915/intel_hdmi.c.
> 
> My receiver currently loses sync when the HDMI output on my computer
> (DG45FC motherboard) is switched from 800x600 (the BIOS resolution) to
> 1920x1080 as part of the boot. Fixable by switching inputs on the receiver
> a couple of times.
> 
> With this patch, my receiver has not lost sync yet (> 40 tries).
> 
> I'm not sure that the general approach is sound, which is why I'm sending
> this out for some feedback and review (in particular, is the SDVOB and SDVOC
> handling in intel_hdmi_set_avi_infoframe() correct?).

Oh, more code duplication... I thought I recognised this, we do this for
SDVO HDMI but not integrated HDMI.

Can you move the dip_infoframe helper functions into intel_hdmi.c and call
them from intel_sdvo.c? And then we can take a closer look at sdvox.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre