All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: Quentin Schulz <foss@0leil.net>, docs@lists.yoctoproject.org
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Quentin Schulz <foss+yocto@0leil.net>
Subject: Re: [docs] [PATCH] documentation: conf.py: add knob for loading appropriate objects.inv
Date: Wed, 8 Dec 2021 16:47:57 +0100	[thread overview]
Message-ID: <913b368e-5cf5-88c0-351f-1338a19a5ce5@bootlin.com> (raw)
In-Reply-To: <20211203103315.57685-1-foss@0leil.net>

Hi Quentin,

On 12/3/21 11:33 AM, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Yocto Project releases use a specific Bitbake release. Currently the
> bitbake: mapping is pointing to the current master version of Bitbake
> documentation. This is an issue if some links disappear over time and
> someone is still building old documentation (which is the case on the YP
> autobuilder for example). Also, the documentation at the current master
> version of Bitbake might not be correct for the Yocto Project version
> associated with the doc the user is currently looking at, potentially
> causing confusion.
>
> In master branch, nothing needs to be done. For release branches, the
> bitbake_version variable needs to be set accordingly. See
> https://wiki.yoctoproject.org/wiki/Releases for the mapping.
>
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>  documentation/conf.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/documentation/conf.py b/documentation/conf.py
> index 8e0847938..1bea18032 100644
> --- a/documentation/conf.py
> +++ b/documentation/conf.py
> @@ -17,6 +17,7 @@ import sys
>  import datetime
>  
>  current_version = "dev"
> +bitbake_version = "" # Leave empty for development branch
>  
>  # String used in sidebar
>  version = 'Version: ' + current_version
> @@ -90,7 +91,7 @@ extlinks = {
>  
>  # Intersphinx config to use cross reference with Bitbake user manual
>  intersphinx_mapping = {
> -    'bitbake': ('https://docs.yoctoproject.org/bitbake/', None)
> +    'bitbake': ('https://docs.yoctoproject.org/bitbake/' + bitbake_version, None)
>  }
>  
>  # Suppress "WARNING: unknown mimetype for ..."

Excellent idea ! Thanks for the patch.
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
... and merged into "master-next".

I'll take care of adapting and applying it on the currently supported
release branches (dunfell, hardknott, honister). I'll do that directly
in the branches, but let me know if I should submit patches first.
Thanks again
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2021-12-08 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 10:33 [PATCH] documentation: conf.py: add knob for loading appropriate objects.inv Quentin Schulz
2021-12-08 15:47 ` Michael Opdenacker [this message]
     [not found] ` <16BED23EAE3BFB75.12270@lists.yoctoproject.org>
2021-12-08 16:33   ` [docs] " Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=913b368e-5cf5-88c0-351f-1338a19a5ce5@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=foss+yocto@0leil.net \
    --cc=foss@0leil.net \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.