All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: sean.wang@mediatek.com, bjorn@mork.no,
	vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org, rene@vdorst.com, john@phrozen.org,
	neil@brown.name
Subject: Re: [PATCHv2 4/4] dt-bindings: net: dsa: add new MT7530 binding to support MT7621
Date: Tue, 15 Jan 2019 15:07:33 +1000	[thread overview]
Message-ID: <91475ef4-2ca1-7341-7b0a-08a8c7e6ee9c@kernel.org> (raw)
In-Reply-To: <20190114140702.GG4635@lunn.ch>

Hi Andrew,

On 15/1/19 12:07 am, Andrew Lunn wrote:
> On Mon, Jan 14, 2019 at 05:03:34PM +1000, gerg@kernel.org wrote:
>> From: Greg Ungerer <gerg@kernel.org>
>>
>> Add devicetree binding to support the compatible mt7530 switch as used
>> in the MediaTek MT7621 SoC.
> 
> Hi Gerg
> 
> It gets messy, but could you try to indicate that core-supply and
> io-supply are not required for your new device. Currently the binding
> indicates they are required for all devices.

Yep, good point. Are you thinking something like this?

--- a/Documentation/devicetree/bindings/net/dsa/mt7530.txt
+++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
@@ -3,16 +3,19 @@ Mediatek MT7530 Ethernet switch

  Required properties:

-- compatible: Must be compatible = "mediatek,mt7530";
+- compatible: may be compatible = "mediatek,mt7530"
+       or compatible = "mediatek,mt7621"
  - #address-cells: Must be 1.
  - #size-cells: Must be 0.
  - mediatek,mcm: Boolean; if defined, indicates that either MT7530 is the part
         on multi-chip module belong to MT7623A has or the remotely standalone
         chip as the function MT7623N reference board provided for.
  - core-supply: Phandle to the regulator node necessary for the core power.
+       (not required on mediatek,mt7621)
  - io-supply: Phandle to the regulator node necessary for the I/O power.
         See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
         for details for the regulator setup on these boards.
+       (not required on mediatek,mt7621)

  If the property mediatek,mcm isn't defined, following property is required


Regards
Greg

  reply	other threads:[~2019-01-15  5:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  7:03 [PATCHv2 0/4]: net: dsa: mt7530: support MT7530 in the MT7621 So gerg
2019-01-14  7:03 ` [PATCHv2 1/4] net: ethernet: mediatek: support MT7621 SoC ethernet hardware gerg
2019-01-14  7:03 ` [PATCHv2 2/4] net: ethernet: mediatek: do not force autonegiation at init gerg
2019-01-14 12:55   ` René van Dorst
2019-01-15  4:51     ` Greg Ungerer
2019-01-14  7:03 ` [PATCHv2 3/4] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC gerg
2019-01-14  7:03 ` [PATCHv2 4/4] dt-bindings: net: dsa: add new MT7530 binding to support MT7621 gerg
2019-01-14 14:07   ` Andrew Lunn
2019-01-15  5:07     ` Greg Ungerer [this message]
2019-01-15 13:18       ` Andrew Lunn
2019-01-16 13:14         ` Greg Ungerer
2019-01-16 16:12           ` Andrew Lunn
2019-01-17  5:17             ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91475ef4-2ca1-7341-7b0a-08a8c7e6ee9c@kernel.org \
    --to=gerg@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=f.fainelli@gmail.com \
    --cc=john@phrozen.org \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=rene@vdorst.com \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.