From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:46366 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbbKGLnI (ORCPT ); Sat, 7 Nov 2015 06:43:08 -0500 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NXG02LP10JUVZ70@mailout3.samsung.com> for linux-wireless@vger.kernel.org; Sat, 07 Nov 2015 20:43:06 +0900 (KST) Date: Sat, 07 Nov 2015 11:43:05 +0000 (GMT) From: Amit Khatri Subject: [PATCH] iw: Fix memory leak if nla_put fails To: "johannes@sipsolutions.net" Cc: "linux-wireless@vger.kernel.org" , Rahul Jain , HEMANSHU SRIVASTAVA , k.ashutosh@samsung.com Reply-to: amit.khatri@samsung.com MIME-version: 1.0 Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <920161889.199041446896585340.JavaMail.weblogic@ep2mlwas04c> (sfid-20151107_124313_057731_F74FAD88) Sender: linux-wireless-owner@vger.kernel.org List-ID: RnJvbSA4MGM5NTZmMTVlZGZlNGY1OWE2YzEzYWU4YWQwOGJlYTBiNzhhYWZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogQW1pdCBLaGF0cmkgPGFtaXQua2hhdHJpQHNhbXN1bmcuY29t Pg0KRGF0ZTogU2F0LCA3IE5vdiAyMDE1IDE3OjAwOjQ3ICswNTMwDQpTdWJqZWN0OiBbUEFUQ0hd IEZpeCBtZW1vcnkgbGVhayBpZiBubGFfcHV0IGZhaWxzDQoNClNpZ25lZC1vZmYtYnk6IEFtaXQg S2hhdHJpIDxhbWl0LmtoYXRyaUBzYW1zdW5nLmNvbT4NClNpZ25lZC1vZmYtYnk6IFJhaHVsIEph aW4gPHJhaHVsLmphaW5Ac2Ftc3VuZy5jb20+DQpTaWduZWQtb2ZmLWJ5OiBBc2h1dG9zaCBLYXVz aGlrIDxrLmFzaHV0b3NoQHNhbXN1bmcuY29tPg0KDQphdm9pZCBtZW1vcnkgbGVhayBiZWNhdXNl IG9mIG5sYV9wdXRfZmFpbHVyZQ0KLS0tDQogY29hbGVzY2UuYyB8ICA3ICsrKysrKy0NCiB3b3ds YW4uYyAgIHwgMjggKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQ0KIDIgZmlsZXMgY2hhbmdl ZCwgMjggaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2NvYWxl c2NlLmMgYi9jb2FsZXNjZS5jDQppbmRleCAzNmRjYWVmLi45YjEzYWIzIDEwMDY0NA0KLS0tIGEv Y29hbGVzY2UuYw0KKysrIGIvY29hbGVzY2UuYw0KQEAgLTEyNCw3ICsxMjQsOCBAQCBzdGF0aWMg aW50IGhhbmRsZV9jb2FsZXNjZV9lbmFibGUoc3RydWN0IG5sODAyMTFfc3RhdGUgKnN0YXRlLA0K IAkJCQkJbmxhX25lc3RfZW5kKG1zZywgbmxfcGF0KTsNCiAJCQkJCWZyZWUobWFzayk7DQogCQkJ CQlmcmVlKHBhdCk7DQotDQorCQkJCQlwYXQ9TlVMTDsNCisJCQkJCW1hc2s9TlVMTDsNCiAJCQkJ CWlmICghbmV4dF9wYXQpDQogCQkJCQkJYnJlYWs7DQogCQkJCQljdXJfcGF0ID0gbmV4dF9wYXQ7 DQpAQCAtMTU1LDYgKzE1NiwxMCBAQCBzdGF0aWMgaW50IGhhbmRsZV9jb2FsZXNjZV9lbmFibGUo c3RydWN0IG5sODAyMTFfc3RhdGUgKnN0YXRlLA0KIAkJZXJyID0gMTsNCiAJZ290byBjbG9zZTsN CiBubGFfcHV0X2ZhaWx1cmU6DQorCWlmKHBhdCkNCisJCWZyZWUocGF0KTsNCisJaWYobWFzaykN CisJCWZyZWUobWFzayk7DQogCWVyciA9IC1FTk9CVUZTOw0KIGNsb3NlOg0KIAlmY2xvc2UoZik7 DQpkaWZmIC0tZ2l0IGEvd293bGFuLmMgYi93b3dsYW4uYw0KaW5kZXggYzMwZWFiNy4uMmUxZDQz ZCAxMDA2NDQNCi0tLSBhL3dvd2xhbi5jDQorKysgYi93b3dsYW4uYw0KQEAgLTg5LDcgKzg5LDEw IEBAIHN0YXRpYyBpbnQgd293bGFuX3BhcnNlX3RjcF9maWxlKHN0cnVjdCBubF9tc2cgKm1zZywg Y29uc3QgY2hhciAqZm4pDQogDQogCQkJaWYgKCFwa3QpDQogCQkJCWdvdG8gY2xvc2U7DQotCQkJ TkxBX1BVVChtc2csIE5MODAyMTFfV09XTEFOX1RDUF9EQVRBX1BBWUxPQUQsIGxlbiwgcGt0KTsN CisJCQlpZihubGFfcHV0KG1zZywgTkw4MDIxMV9XT1dMQU5fVENQX0RBVEFfUEFZTE9BRCwgbGVu LCBwa3QpIDwgMCl7DQorCQkJCWZyZWUocGt0KTsNCisJCQkJZ290byBubGFfcHV0X2ZhaWx1cmU7 DQorCQkJfQ0KIAkJCWZyZWUocGt0KTsNCiAJCX0gZWxzZSBpZiAoc3RybmNtcChidWYsICJkYXRh LmludGVydmFsPSIsIDE0KSA9PSAwKSB7DQogCQkJTkxBX1BVVF9VMzIobXNnLCBOTDgwMjExX1dP V0xBTl9UQ1BfREFUQV9JTlRFUlZBTCwNCkBAIC05NywxMyArMTAwLDIwIEBAIHN0YXRpYyBpbnQg d293bGFuX3BhcnNlX3RjcF9maWxlKHN0cnVjdCBubF9tc2cgKm1zZywgY29uc3QgY2hhciAqZm4p DQogCQl9IGVsc2UgaWYgKHN0cm5jbXAoYnVmLCAid2FrZT0iLCA1KSA9PSAwKSB7DQogCQkJdW5z aWduZWQgY2hhciAqcGF0LCAqbWFzazsNCiAJCQlzaXplX3QgcGF0bGVuOw0KLQ0KIAkJCWlmIChw YXJzZV9oZXhfbWFzayhidWYgKyA1LCAmcGF0LCAmcGF0bGVuLCAmbWFzaykpDQogCQkJCWdvdG8g Y2xvc2U7DQotCQkJTkxBX1BVVChtc2csIE5MODAyMTFfV09XTEFOX1RDUF9XQUtFX01BU0ssDQot CQkJCURJVl9ST1VORF9VUChwYXRsZW4sIDgpLCBtYXNrKTsNCi0JCQlOTEFfUFVUKG1zZywgTkw4 MDIxMV9XT1dMQU5fVENQX1dBS0VfUEFZTE9BRCwNCi0JCQkJcGF0bGVuLCBwYXQpOw0KKwkJCWlm KG5sYV9wdXQobXNnLCBOTDgwMjExX1dPV0xBTl9UQ1BfV0FLRV9NQVNLLA0KKwkJCQlESVZfUk9V TkRfVVAocGF0bGVuLCA4KSwgbWFzaykgPCAwKXsNCisJCQkJZnJlZShtYXNrKTsNCisJCQkJZnJl ZShwYXQpOw0KKwkJCQlnb3RvIG5sYV9wdXRfZmFpbHVyZTsNCisJCQl9DQorCQkJaWYobmxhX3B1 dChtc2csIE5MODAyMTFfV09XTEFOX1RDUF9XQUtFX1BBWUxPQUQsDQorCQkJCXBhdGxlbiwgcGF0 KSA8IDApew0KKwkJCQlmcmVlKHBhdCk7DQorCQkJCWZyZWUobWFzayk7DQorCQkJCWdvdG8gbmxh X3B1dF9mYWlsdXJlOw0KKwkJCX0NCiAJCQlmcmVlKG1hc2spOw0KIAkJCWZyZWUocGF0KTsNCiAJ CX0gZWxzZSBpZiAoc3RybmNtcChidWYsICJkYXRhLnNlcT0iLCA5KSA9PSAwKSB7DQpAQCAtMjk5 LDYgKzMwOSw4IEBAIHN0YXRpYyBpbnQgaGFuZGxlX3dvd2xhbl9lbmFibGUoc3RydWN0IG5sODAy MTFfc3RhdGUgKnN0YXRlLA0KIAkJCW5sYV9uZXN0X2VuZChwYXR0ZXJucywgcGF0dGVybik7DQog CQkJZnJlZShtYXNrKTsNCiAJCQlmcmVlKHBhdCk7DQorCQkJcGF0PU5VTEw7DQorCQkJbWFzaz1O VUxMOw0KIAkJCWJyZWFrOw0KIAkJfQ0KIAkJYXJndisrOw0KQEAgLTMxMiw2ICszMjQsMTAgQEAg c3RhdGljIGludCBoYW5kbGVfd293bGFuX2VuYWJsZShzdHJ1Y3Qgbmw4MDIxMV9zdGF0ZSAqc3Rh dGUsDQogCW5sYV9uZXN0X2VuZChtc2csIHdvd2xhbik7DQogCWVyciA9IDA7DQogIG5sYV9wdXRf ZmFpbHVyZToNCisJaWYocGF0KQ0KKwkJZnJlZShwYXQpOw0KKwlpZihtYXNrKQ0KKwkJZnJlZSht YXNrKTsNCiAJbmxtc2dfZnJlZShwYXR0ZXJucyk7DQogCXJldHVybiBlcnI7DQogfQ0KLS0gDQox LjkuMQ0K