All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>,
	Realtek linux nic maintainers <nic_swsd@realtek.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 0/2] r8169: improve RTL8168g PHY suspend quirk
Date: Wed, 6 Jan 2021 11:44:53 +0100	[thread overview]
Message-ID: <9303c2cf-c521-beea-c09f-63b5dfa91b9c@gmail.com> (raw)

According to Realtek the ERI register 0x1a8 quirk is needed to work
around a hw issue with the PHY on RTL8168g. The register needs to be
changed before powering down the PHY. Currently we don't meet this
requirement, however I'm not aware of any problems caused by this.
Therefore I see the change as an improvement.

The PHY driver has no means to access the chip ERI registers,
therefore we have to intercept MDIO writes to the BMCR register.
If the BMCR_PDOWN bit is going to be set, then let's apply the
quirk before actually powering down the PHY.

Heiner Kallweit (2):
  r8169: move ERI access functions to avoid forward declaration
  r8169: improve RTL8168g PHY suspend quirk

 drivers/net/ethernet/realtek/r8169_main.c | 180 +++++++++++-----------
 1 file changed, 90 insertions(+), 90 deletions(-)

-- 
2.30.0


             reply	other threads:[~2021-01-06 10:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 10:44 Heiner Kallweit [this message]
2021-01-06 10:47 ` [PATCH net-next 1/2] r8169: move ERI access functions to avoid forward declaration Heiner Kallweit
2021-01-06 10:49 ` [PATCH net-next 2/2] r8169: improve RTL8168g PHY suspend quirk Heiner Kallweit
2021-01-07 23:10 ` [PATCH net-next 0/2] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9303c2cf-c521-beea-c09f-63b5dfa91b9c@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.